Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 64: INTEL_CAR_NEM Changes being made in this file should have appropriate information in commit message explaining the reason for the change. Also, if there are more changes required to fix things, it would be ideal to add TODOs.
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 84: 0x30000 This CL conflicts with https://review.coreboot.org/c/coreboot/+/37764/. Can you please sync up with Maulik?
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 147: 7 Is this really correct?
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 151: 8 I see only 6 in EDS.
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 159: 0xfe03e000 Why was this changed?
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 165: 0x25A Please use lower case for hex characters to keep it consistent with other hex values in this file.
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco... PS8, Line 169: 0x7FFF Why did the values for M/N change?
-
Furquan Shaikh (Code Review)