Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71236 )
Change subject: soc/intel: Create common function to check PCH slot
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/irq.h:
https://review.coreboot.org/c/coreboot/+/71236/comment/f952142d_fda43eb8
PS5, Line 71: a slot belongs to PCH IP of SoC die or is a root
: * port from IOE die.
nit: a slot belongs to the SoC or IOE die.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fc850228b7ddbf84e2feb2433adff5e4002033
Gerrit-Change-Number: 71236
Gerrit-PatchSet: 6
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 07:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment