Change in ...coreboot[master]: mb/google/octopus: Add keyboard backlight support for Droid/Blorb
Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32298
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
mb/google/octopus: Add keyboard backlight support for Droid/Blorb
Droid/Blorb supports keyboard backlight feature, so enable the ASL code.
BUG=b:130330141 BRANCH=octopus TEST=Build and boot to OS, verify that the string 'KBLT' is in the DSDT.
Change-Id: I74684e3905d34b61fa4b851798dbca018f986e5a Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bobba/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32298/1
diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h index 16f931b..196d52e 100644 --- a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h @@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
Patch Set 1: Code-Review+1
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
Patch Set 1: Code-Review+1
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32298/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bobba/include/variant/ec.h:
https://review.coreboot.org/#/c/32298/1/src/mainboard/google/octopus/variant... PS1, Line 22: #define EC_ENABLE_KEYBOARD_BACKLIGHT It looks like the ASL asks the EC if there's a backlight, so this looks fine by me: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb ......................................................................
mb/google/octopus: Add keyboard backlight support for Droid/Blorb
Droid/Blorb supports keyboard backlight feature, so enable the ASL code.
BUG=b:130330141 BRANCH=octopus TEST=Build and boot to OS, verify that the string 'KBLT' is in the DSDT.
Change-Id: I74684e3905d34b61fa4b851798dbca018f986e5a Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32298 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/bobba/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved David Wu: Looks good to me, but someone else must approve Sheng-Liang Pan: Looks good to me, but someone else must approve Marco Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h index 16f931b..196d52e 100644 --- a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h @@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
-
David Wu (Code Review) -
Furquan Shaikh (Code Review)
-
Justin TerAvest (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Sheng-Liang Pan (Code Review)