Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48002 )
Change subject: mb/google/zork: Add Shuboz GPIO to proto support ......................................................................
mb/google/zork: Add Shuboz GPIO to proto support
1. AGPIO5 to NC 2. AGPIO6 - EN_PWR_TOUCHPAD_R to HIGH 3. EGPIO141 to NC 4. EGPIO144 to NC
BUG=b:none BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48002/1
diff --git a/src/mainboard/google/zork/variants/shuboz/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/Makefile.inc index 295acd2..2a8f0f7 100644 --- a/src/mainboard/google/zork/variants/shuboz/Makefile.inc +++ b/src/mainboard/google/zork/variants/shuboz/Makefile.inc @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-or-later
subdirs-y += ./spd +ramstage-y += gpio.c diff --git a/src/mainboard/google/zork/variants/shuboz/gpio.c b/src/mainboard/google/zork/variants/shuboz/gpio.c new file mode 100644 index 0000000..2ff5ae9 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/gpio.c @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boardid.h> +#include <gpio.h> +#include <soc/gpio.h> +#include <ec/google/chromeec/ec.h> + +static const struct soc_amd_gpio bid_gpio_set_stage_ram[] = { + /* AGPIO_5 - NC */ + PAD_NC(GPIO_5), + /* AGPIO6 - EN_PWR_TOUCHPAD_R */ + PAD_GPO(GPIO_32, HIGH), + /* EGPIO141 - NC */ + PAD_NC(GPIO_141), + /* EGPIO144 - NC (etk5515 not used) */ + PAD_NC(GPIO_144), +}; + +const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) +{ + *size = ARRAY_SIZE(bid_gpio_set_stage_ram); + return bid_gpio_set_stage_ram; +}
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48002
to look at the new patch set (#2).
Change subject: mb/google/zork: Add Shuboz GPIO to proto support ......................................................................
mb/google/zork: Add Shuboz GPIO to proto support
1. AGPIO5 to NC 2. AGPIO32 - EN_PWR_TOUCHSCREEN to HIGH 3. EGPIO141 to NC 4. EGPIO144 to NC
BUG=b:none BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48002/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48002
to look at the new patch set (#3).
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
mb/google/zork: Add GPIO to Shuboz support
1. AGPIO5 to NC 2. AGPIO32 - EN_PWR_TOUCHSCREEN to HIGH 3. EGPIO141 to NC 4. EGPIO144 to NC
BUG=b:none BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48002/3
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Bhanu Prakash Maiya,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48002
to look at the new patch set (#4).
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
mb/google/zork: Add GPIO to Shuboz support
1. AGPIO5 to NC 2. AGPIO32 - EN_PWR_TOUCHSCREEN to HIGH 3. EGPIO141 to NC 4. EGPIO144 to NC
BUG=b:174528384 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48002/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Bhanu Prakash Maiya,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48002
to look at the new patch set (#5).
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
mb/google/zork: Add GPIO to Shuboz support
1. AGPIO5 to NC 2. EGPIO141 to NC 3. EGPIO144 to NC
BUG=b:174528384 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48002/5
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48002 )
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
Patch Set 5: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48002 )
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
Patch Set 5: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48002 )
Change subject: mb/google/zork: Add GPIO to Shuboz support ......................................................................
mb/google/zork: Add GPIO to Shuboz support
1. AGPIO5 to NC 2. EGPIO141 to NC 3. EGPIO144 to NC
BUG=b:174528384 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I51f291476e01982e1a3f92cd1b338a528434112d Reviewed-on: https://review.coreboot.org/c/coreboot/+/48002 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/gpio.c 2 files changed, 24 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/shuboz/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/Makefile.inc index 295acd2..2a8f0f7 100644 --- a/src/mainboard/google/zork/variants/shuboz/Makefile.inc +++ b/src/mainboard/google/zork/variants/shuboz/Makefile.inc @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-or-later
subdirs-y += ./spd +ramstage-y += gpio.c diff --git a/src/mainboard/google/zork/variants/shuboz/gpio.c b/src/mainboard/google/zork/variants/shuboz/gpio.c new file mode 100644 index 0000000..0fd867e --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/gpio.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boardid.h> +#include <gpio.h> +#include <soc/gpio.h> +#include <ec/google/chromeec/ec.h> + +static const struct soc_amd_gpio bid_gpio_set_stage_ram[] = { + /* AGPIO_5 - NC */ + PAD_NC(GPIO_5), + /* EGPIO141 - NC */ + PAD_NC(GPIO_141), + /* EGPIO144 - NC (etk5515 not used) */ + PAD_NC(GPIO_144), +}; + +const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) +{ + *size = ARRAY_SIZE(bid_gpio_set_stage_ram); + return bid_gpio_set_stage_ram; +}
-
Hung-Te Lin (Code Review) -
Kane Chen (Code Review)
-
Martin Roth (Code Review)