Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
sb/lynxpoint/gpio: fix interrupt storm
On newer kernels (> 4.9 LTS), the GPIO ACPI device's interrupt resource causes an interrupt storm which prevents the CPU from properly idling, significantly increasing power consumption. This was fixed for soc/broadwell (which also supports lynxpoint-lp) by removing the interrupt resource, so apply the same fix here.
Original fix: https://chromium-review.googlesource.com/203645
Test: build/boot google/wolf, verify CPU0 idles correctly and power consumption drop via powertop in kernels 4.16.18 and 5.x.
Change-Id: Ic4963f2f0225b5f44a7604b0107911640345c855 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39578/1
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 88138a1..2a3c096 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -551,8 +551,9 @@ , // ResourceSourceIndex , // ResourceSource BAR0) - Interrupt (ResourceConsumer, - Level, ActiveHigh, Shared, , ,) {14} + // Disabled due to IRQ storm: http://crosbug.com/p/29548 + //Interrupt (ResourceConsumer, + // Level, ActiveHigh, Shared, , , ) {14} })
Method (_CRS, 0, NotSerialized)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG@10 PS1, Line 10: resource causes an interrupt storm which prevents the CPU Is that a hardware bug?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG@10 PS1, Line 10: resource causes an interrupt storm which prevents the CPU
Is that a hardware bug?
hard to say, the chromium gerrit link discusses it a bit more, it would be a case of incorrect documentation
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39578/1//COMMIT_MSG@10 PS1, Line 10: resource causes an interrupt storm which prevents the CPU
Is that a hardware bug? […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
sb/lynxpoint/gpio: fix interrupt storm
On newer kernels (> 4.9 LTS), the GPIO ACPI device's interrupt resource causes an interrupt storm which prevents the CPU from properly idling, significantly increasing power consumption. This was fixed for soc/broadwell (which also supports lynxpoint-lp) by removing the interrupt resource, so apply the same fix here.
Original fix: https://chromium-review.googlesource.com/203645
Test: build/boot google/wolf, verify CPU0 idles correctly and power consumption drop via powertop in kernels 4.16.18 and 5.x.
Change-Id: Ic4963f2f0225b5f44a7604b0107911640345c855 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39578 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 88138a1..2a3c096 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -551,8 +551,9 @@ , // ResourceSourceIndex , // ResourceSource BAR0) - Interrupt (ResourceConsumer, - Level, ActiveHigh, Shared, , ,) {14} + // Disabled due to IRQ storm: http://crosbug.com/p/29548 + //Interrupt (ResourceConsumer, + // Level, ActiveHigh, Shared, , , ) {14} })
Method (_CRS, 0, NotSerialized)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39578 )
Change subject: sb/lynxpoint/gpio: fix interrupt storm ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1393 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1392 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1391
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)