Attention is currently required from: Maximilian Brune.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76689?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/sifive/fu740: Add FU740 SOC
......................................................................
Patch Set 12:
(1 comment)
File src/soc/sifive/fu740/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76689/comment/a76e695f_d45589eb :
PS12, Line 3: ifdef
This needs to be `ifeq ($(CONFIG_SOC_SIFIVE_FU740),y)`
This config will always be defined.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a
Gerrit-Change-Number: 76689
Gerrit-PatchSet: 12
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Jan Samek
jan.samek@siemens.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Marvin Drees
marvin.drees@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sat, 02 Mar 2024 17:41:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment