Change in coreboot[master]: drivers/acpi: Add device tree driver to generate thermal zone
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54132 )
Change subject: drivers/acpi: Add device tree driver to generate thermal zone ......................................................................
Patch Set 2:
(6 comments)
File src/drivers/acpi/thermal_zone/chip.h:
https://review.coreboot.org/c/coreboot/+/54132/comment/a977d786_61776e57 PS1, Line 13: /* Name of the thermal zone */ : const char *name;
suggestion: since this is for _STR, maybe use `description` instead of `name` ? My first thought was […]
Done
https://review.coreboot.org/c/coreboot/+/54132/comment/bcc01e7c_3fe77459 PS1, Line 28: acpi_thermal_zone_passive_config
I don't think the struct name is required
Reworked the units to be seconds. ms doesn't really make sense.
https://review.coreboot.org/c/coreboot/+/54132/comment/c09b5c42_1b230f36 PS1, Line 51: acpigen_write_thermal_zone_get_temperature
Having had a bad nights sleep ;) […]
Done
File src/drivers/acpi/thermal_zone/thermal_zone.c:
https://review.coreboot.org/c/coreboot/+/54132/comment/f18012eb_6c283692 PS1, Line 57: K
deci-kelvin
Done
https://review.coreboot.org/c/coreboot/+/54132/comment/12822244_f0cd5cfb PS1, Line 76: dev_count_cpu
lol, maybe I'll file a bug :)
https://review.coreboot.org/c/coreboot/+/54132/comment/89662769_8c565caa PS1, Line 87: if (acpigen_write_thermal_zone_get_temperature(config) != CB_SUCCESS) : printk(BIOS_ERR, "Failed to write _TMP for %s.%s\n", scope, name);
Does this callback need to have a return value? […]
Nope.
-
Raul Rangel (Code Review)