Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config ......................................................................
Patch Set 46:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35499/39/src/soc/qualcomm/sc7180/bo... File src/soc/qualcomm/sc7180/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35499/39/src/soc/qualcomm/sc7180/bo... PS39, Line 20: #include <soc/qi2s.h>
removed this header file.
Done
https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/qcom_qup_se.h:
https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/in... PS26, Line 233:
removed this struct as we are not using it anymore
Done
https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/qupv3_config.h:
https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/in... PS40, Line 54: #define QUPV3_UART_SRC_HZ 7372800
*ping* […]
Done
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 19: se_mappings
Is this supposed to be static?
Done
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 28: Fingerprint
Not EC, H1. […]
Done
https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/qu... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/qu... PS26, Line 37: struct se_cfg *scfg)
Done the changes
Done
https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/qu... PS26, Line 220: printk(BIOS_INFO, "%s: *ERROR* *PROTOCOL MISMATCH****\n",
Done the changes as per the comments
Done
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... PS44, Line 21: unsigned int mode)
Okay, if we think that mainboards may need to individually select other modes I guess that's okay.
Done
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... PS44, Line 30: const char *filename[] = {
done
Done
-
Julius Werner (Code Review)