build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 381: #define CG1PLL_SS_STEP_SIZE_DSFRAC_MASK (0xffff << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 383: #define CG1PLL_SS_AMOUNT_DSFRAC_MASK (0xffff << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 386: #define CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK (0xf << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 598: cfg4 |= (0xd000 << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) & CG1PLL_SS_AMOUNT_DSFRAC_MASK; line over 80 characters
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 600: cfg4 |= (0x02d5 << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) & CG1PLL_SS_STEP_SIZE_DSFRAC_MASK; line over 80 characters