Attention is currently required from: Arthur Heymans, Christian Walter, Jeff Daly, Johnny Lin, Marek Maślanka, Sean Rhodes, Tim Chu, Vanessa Eusebio.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80005?usp=email )
Change subject: soc/intel: Unify the definition of TCO registers
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80005/comment/8d2b3b75_30e17da2 :
PS6, Line 9: Move TCO registers definition to a separate file and use it
: consistently.
Please add, why some TCO definitions still stay in different files sometimes.
File src/soc/intel/common/tco.h:
https://review.coreboot.org/c/coreboot/+/80005/comment/e85c005a_6dc2e9bd :
PS6, Line 11: TCO_STS_TCO_SLVSEL
Some symbols have TCO numbers and some do not. I think they should be unified in that regard, so IMO all symbols should have TCO1_, TCO2_ etc if they describe fields of TCOn.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6
Gerrit-Change-Number: 80005
Gerrit-PatchSet: 6
Gerrit-Owner: Marek Maślanka
mmaslanka@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Marek Maślanka
mmaslanka@google.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 17 Jan 2024 10:24:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment