Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28867 )
Change subject: mb/google/poppy/variant/nocturne: set GPP_C19 to NF1
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28867/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/28867/1//COMMIT_MSG@7
PS1, Line 7: set GPP_C19 to NF1
It might be better to just say that this CL is updating GPIO configuration since it is affecting more than GPP_C19.
--
To view, visit
https://review.coreboot.org/28867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e972dbe4214cdd15d80d63dfa058e7755f7ecbb
Gerrit-Change-Number: 28867
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Oct 2018 00:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No