Attention is currently required from: Keith Hui.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61537 )
Change subject: Documentation: Add Asus P2B-LS ......................................................................
Patch Set 2: Code-Review+1
(7 comments)
File Documentation/mainboard/asus/p2b-ls.md:
https://review.coreboot.org/c/coreboot/+/61537/comment/8a512988_31202091 PS2, Line 9: ethernet The model names probably refer to this as "LAN". No need to change anything.
https://review.coreboot.org/c/coreboot/+/61537/comment/2bf95563_0cd7e6ee PS2, Line 19: SST 39SF020A (or similar) It would be good to specify the flash protocol
https://review.coreboot.org/c/coreboot/+/61537/comment/74fdfdee_d9145eae PS2, Line 42: This board by default Nit:
By default, this board ...
https://review.coreboot.org/c/coreboot/+/61537/comment/2ff1edb6_504b30bc PS2, Line 45: If you start to run out of flash space, you may have : to build a custom microcode update file by manually concatenating files in : 3rdparty/intel-microcode/intel-ucode for CPU models that you actually have : on hand. You could add Kconfig options to control which microcode updates are added. The default should be to add all of them, for build-testing purposes.
This would be handled in a separate change.
https://review.coreboot.org/c/coreboot/+/61537/comment/e09d17a6_eea0006d PS2, Line 69: nit: trailing whitespace
https://review.coreboot.org/c/coreboot/+/61537/comment/962465d9_ad60f546 PS2, Line 91: S3 suspend to RAM Out of curiosity, got any details on what goes wrong?
https://review.coreboot.org/c/coreboot/+/61537/comment/e97a4296_0e5f207b PS2, Line 101: model_6xx Would be nice to indicate the actual models and CPU socket (slot 1?)
-
Angel Pons (Code Review)