Change in coreboot[master]: console: Update for vboot before bootblock - coreboot-gerrit

9 Jun 2020


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41815 )
Change subject: console: Update for vboot before bootblock
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c 
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c@70 
PS6, Line 70: CONFIG(EARLY_PCI_BRIDGE)
...
If I understand this correctly you want to support EARLY_PCI_BRIDGE […]
I think you missed one negation there? It was stated elsewhere PCI config does not work inside psp-verstage. I had comment on patchset #4 for alternative solution.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc9fb0810e0816fe0a68e52287eda6145043a619
Gerrit-Change-Number: 41815
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jun 2020 08:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment