Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41630 )
Change subject: soc/amd/picasso: rewrite soc_util ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41630/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/41630/1/src/soc/amd/picasso/soc_uti... PS1, Line 115: silicon = SILICON_RV2;
Done
Well, I don't really mind the braces. If you prefer to use them, feel free to. Just expect an angery Jenkins to yell at you for it 😄
https://review.coreboot.org/c/coreboot/+/41630/5/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/41630/5/src/soc/amd/picasso/soc_uti... PS5, Line 143: SOC_PICASSO Same story happens here, doesn't it?
-
Angel Pons (Code Review)