Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61390 )
Change subject: soc/mediatek/mt8186: Add register protect control for MT6366 ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61390/comment/9b625dc2_9b53da63 PS1, Line 10:
the
Done
https://review.coreboot.org/c/coreboot/+/61390/comment/6ba1617e_67722f30 PS1, Line 11: after the init setting is : done
afterward
Done
https://review.coreboot.org/c/coreboot/+/61390/comment/c879a6a9_b2f7d0ff PS1, Line 15: setting
set
Done
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/61390/comment/affe1906_c3f3d4e4 PS1, Line 780: static void mt6366_protect_control(bool en_protect)
Please call this function from wk_power_down_seq() and pmic_set_vddq_vol().
Done
https://review.coreboot.org/c/coreboot/+/61390/comment/60821838_44fd3bc2 PS1, Line 782: struct pmic_setting tma_setting = {0x3A8, 0x0, 0xFFFF, 0}; : tma_setting.val = en_protect ? 0 : 0x9CA7; : : pwrap_write_field(tma_setting.addr, tma_setting.val, : tma_setting.mask, tma_setting.shift);
Rewrite as […]
Done