Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT
Already selected from northbridge Kconfig.
Change-Id: I5a30769b4186041a15fd1264bb0d6efa32cb6eb4 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/intel/d510mo/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/49182/1
diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 93ce389..e0aed55 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -11,7 +11,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index cd6260b..6e7552c 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -11,7 +11,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
Patch Set 1: Code-Review+1
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
Patch Set 1: Code-Review+1
The native code only supports VGA, which is board dependent. Maybe remove the Kconfig option from the NB instead?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
The native code only supports VGA, which is board dependent. Maybe remove the Kconfig option from the NB instead?
Hmm, TIL. If we ever hit that case, maybe we should just port pineview to libgfxinit instead?
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT ......................................................................
pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT
Already selected from northbridge Kconfig.
Change-Id: I5a30769b4186041a15fd1264bb0d6efa32cb6eb4 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49182 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/intel/d510mo/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 93ce389..e0aed55 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -11,7 +11,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index cd6260b..6e7552c 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -11,7 +11,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Singer (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)