Attention is currently required from: Bora Guvendik, Lance Zhao, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 )
Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device.
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/pcie/rtd3/chip.h:
https://review.coreboot.org/c/coreboot/+/61352/comment/41450615_d9e205b4
PS5, Line 9: ACPI_PCIE_RP_EMIT_NONE = 0x00, /* None */
: ACPI_PCIE_RP_EMIT_L23 = 0x01, /* L23 */
: ACPI_PCIE_RP_EMIT_PSD0 = 0x02, /* PSD0 */
: ACPI_PCIE_RP_EMIT_SRCK = 0x04, /* SRCK */
: ACPI_PCIE_RP_EMIT_L23_PSD0 = 0x03, /* L23, PSD0 */
: ACPI_PCIE_RP_EMIT_L23_SRCK = 0x05, /* L23, SRCK */
: ACPI_PCIE_RP_EMIT_PSD0_SRCK = 0x06, /* PSD0, SRCK */
: ACPI_PCIE_RP_EMIT_ALL = 0x07 /* L23, PSD0, SRCK */
: };
Since we don't want the default behavior of this driver to change, ACPI_PCIE_RP_EMIT_ALL should be `0`, because boards that do not set `ext_pm_support` (i.e., all the current boards) still need those Methods defined for where this driver is currently used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79de76f26c8424b036cb7d2719df68937599ca2f
Gerrit-Change-Number: 61352
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Feb 2022 18:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment