Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 76:
(5 comments)
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 9: select MAINBOARD_USES_FSP2_0
already selected by SOC_INTEL_KABYLAKE
Done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 18: config SOC_INTEL_COMMON_BLOCK_SGX
is this needed? SOC_INTEL_COMMON_BLOCK_SGX is selected by SOC_INTEL_KABYLAKE/SOC_INTEL_COMMON_SKYLAK […]
Done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 76: endif
endif # BOARD_SUPERMICRO_BASEBOARD_X11SSH
Done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/board_info.txt:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 5: ROM socketed: n
both, UEFI and BMC rom are socketed
They aren't.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 5: ROM socketed: n
both, UEFI and BMC rom are socketed
They aren't.
-
Felix Singer (Code Review)