Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81354?usp=email )
Change subject: mb/google/brya: Fix mux_conn index used by ec/google/chromeec
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Interesting, when I did the felwinter project. I already verified all the USB. […]
We see an issue when we apply the first patch in this series where we try to copy _PLD from usb port to mux. PMC mux conn1 uses usbX_port2 and conn2 uses usbX_port3. So, conn1's PLD is to be copied from usbX_port2 and conn2's PLD is to be copied from usbX_port3.
The issue is that `fill_ssdt_typec_device` in `ec_acpi.c` matches conn1 to usbX_port3 and conn2 to usbX_port2, which are reversed. The reason is that given index i, mux_conn[i] is matched with usb port's PLD group token of i+1, so mux_conn[0] is matched with usbX_port2 with group token of 1 and mux_conn[1] is matched with usbX_port3 with group token of 2. Since mux_conn[0] is conn2 and mux_conn[1] is conn1, this matching is swapped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81354?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I349682a6fe3fe4848e4e86d9c446530a31b35875
Gerrit-Change-Number: 81354
Gerrit-PatchSet: 4
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benson Leung
bleung@google.com
Gerrit-CC: Emilie Roberts
hadrosaur@google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 20 Mar 2024 02:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment