Attention is currently required from: Nico Huber, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67489 )
Change subject: common/gma-registers: Update for Tiger Lake ......................................................................
Patch Set 2:
(5 comments)
File common/hw-gfx-gma-registers.ads:
https://review.coreboot.org/c/libgfxinit/+/67489/comment/3395f8bc_dabf642f PS1, Line 1787: GEN9_CHICKEN_DPCR_3
Linux calls it GEN9_CLKGATE_DIS_3, c/p error maybe?
sounds right, will fix
https://review.coreboot.org/c/libgfxinit/+/67489/comment/fd7f7141_85d8ec7c PS1, Line 1987: HIP_INDEX_REG1 => 16#10_10a4# / Register_Width,
Given that the indexed registers below are (almost?) grouped […]
Sure let me try something
https://review.coreboot.org/c/libgfxinit/+/67489/comment/be8e99ce_7f5bcf7e PS1, Line 2030: COLD
Isn't it COLD*ST*? That's what I see in Linux and (not sure if related […]
Oh yah missed the ST
https://review.coreboot.org/c/libgfxinit/+/67489/comment/72dcd992_c173733c PS1, Line 2120: PLANE_COLOR_CTL_1_C => 16#07_21cc# / Register_Width,
Isn't there a fourth pipe now?
Yes, I figured adding support for the 4th pipe would be in a separate patch train, since it would touch I think a bunch of different stuff
https://review.coreboot.org/c/libgfxinit/+/67489/comment/2e99152a_feea67c3 PS1, Line 2134: PORT_TX_DFLEXDPPMS_FIA3 => 16#16_f890# / Register_Width, : PORT_TX_DFLEXDPMLE1_FIA3 => 16#16_f8c0# / Register_Width,
These two lines are switched compared to the respective ones above. I assume […]
yeah my eyes glaze over sometimes seeing all of those similar names in a row.. 😄
-
Tim Wawrzynczak (Code Review)