Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37871/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37871/7//COMMIT_MSG@7
PS7, Line 7:
2 spaces?
Done
https://review.coreboot.org/c/coreboot/+/37871/7//COMMIT_MSG@9
PS7, Line 9: type C
Type-C
Ack
https://review.coreboot.org/c/coreboot/+/37871/7//COMMIT_MSG@10
PS7, Line 10: in order to
: get status of the Type C ports
:
get the PD status and configure the PMC.
Ack
https://review.coreboot.org/c/coreboot/+/37871/7//COMMIT_MSG@13
PS7, Line 13: built and booted TGL U RVP
able to boot to OS from USB-C thumbdrive
this patch does not enable boot from USB C
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd3ed262fc700ccc891ec68997a108f5bfbaf9ed
Gerrit-Change-Number: 37871
Gerrit-PatchSet: 9
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Comment-Date: Thu, 30 Jan 2020 23:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Comment-In-Reply-To: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-MessageType: comment