Attention is currently required from: Hung-Te Lin, Jarried Lin, Nancy Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )
Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................
Patch Set 9: Code-Review+1
(5 comments)
Patchset:
PS9:
few nits
File src/soc/mediatek/mt8196/ddp.c:
https://review.coreboot.org/c/coreboot/+/85950/comment/c591ac73_43bed4b3?usp... :
PS9, Line 267: BIT(28) | BIT(31));
exceed 96 characters
https://review.coreboot.org/c/coreboot/+/85950/comment/f24fd363_075af5ae?usp... :
PS9, Line 291: d
%u
https://review.coreboot.org/c/coreboot/+/85950/comment/686eb6c3_46352e49?usp... :
PS9, Line 301: d
%u
https://review.coreboot.org/c/coreboot/+/85950/comment/694474b6_e0eba7e4?usp... :
PS9, Line 306: %d/%d exceed hw limit %d\
use %u
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466
Gerrit-Change-Number: 85950
Gerrit-PatchSet: 9
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 13:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes