Attention is currently required from: Nico Huber, Krishna Prabhakaran, Maulik V Vaghela, Selma Bensaid, Angel Pons, Subrata Banik, Meera Ravindranath, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1
......................................................................
Patch Set 16:
(4 comments)
File src/drivers/intel/gma/opregion.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123678):
https://review.coreboot.org/c/coreboot/+/52758/comment/1b99f988_6421d349
PS16, Line 150: * Physical (2.0) or relative from opregion (2.1+)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123678):
https://review.coreboot.org/c/coreboot/+/52758/comment/f6bc6915_aab5cae6
PS16, Line 151: * address of Raw VBT Data
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123678):
https://review.coreboot.org/c/coreboot/+/52758/comment/a8f4d916_b20c4424
PS16, Line 152: */
trailing whitespace
File src/drivers/intel/gma/opregion.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123678):
https://review.coreboot.org/c/coreboot/+/52758/comment/99ac31e4_292ad6af
PS16, Line 348:
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 16
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 09 Jul 2021 08:03:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment