[M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change

[Paweł Anikiel (Code Review)]

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paul Menzel, Subrata Banik.

Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email )

Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
......................................................................

Patch Set 5:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78297/comment/827f6c11_d9556a3a :
PS4, Line 13: TEST=Compiled and tested on google/redrix
> Tested how exactly?

I included a description.

File src/drivers/wwan/fm/acpi_fm350gl.c:

https://review.coreboot.org/c/coreboot/+/78297/comment/ea45cb25_ad95fb15 :
PS3, Line 6: #if CONFIG(GENERIC_GPIO_LIB)
           : #include <gpio.h>
           : #endif
> Same as below, it's copied over from `acpi/device.c`.

I took a look, and I think including the file unconditionally should work.

https://review.coreboot.org/c/coreboot/+/78297/comment/ec6854d1_b069f568 :
PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB)
> > I needed to get the pin number and the GPIO controller's scope name from a `struct acpi_gpio`. […]

I changed it to an if statement as you suggested. As for bailing out early, `acpi_device_write_gpio()` seems to just use the value it got from `pins[0]`.

File src/drivers/wwan/fm/acpi_fm350gl.c:

https://review.coreboot.org/c/coreboot/+/78297/comment/305d0a5c_11da4a2b :
PS4, Line 293: 		       __func__);
> Please also print out pin value.

Done