Attention is currently required from: Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55023 )
Change subject: arch/x86/acpi_bert_storage: change return type of bert_errors_present
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/arch/x86/acpi_bert_storage.c:
https://review.coreboot.org/c/coreboot/+/55023/comment/96e1dc4c_5551f8f5
PS2, Line 23: int
retype this too?
https://review.coreboot.org/c/coreboot/+/55023/comment/17b2799a_fda44ddb
PS2, Line 38: return bert_region_broken ? 0 : !!bert_region_used;
How about:
return !bert_region_broken && bert_region_used;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d6472deeb26ba92d257761df069e32d9b2e5d4
Gerrit-Change-Number: 55023
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 28 May 2021 15:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment