Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: Add Bay Trail support
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx...
File common/valleyview/hw-gfx-gma-plls.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx...
PS34, Line 421: elsif Target_Clock <= 340_000_000 then
Maximum is 300MHz, `VCO_Upper / P1_Lower / P2_Lower / 5`.
I'll try to use a constant local
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/42359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If81b1268c69b64fa30384f629f1eb43bda15ef52
Gerrit-Change-Number: 42359
Gerrit-PatchSet: 36
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Name of user not set #1002789
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 07:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment