HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44097 )
Change subject: src: Remove unused '<option.h>' ......................................................................
src: Remove unused '<option.h>'
Change-Id: Icb79d60e9ec70a0780d5231698b88cff1db72c9b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/pc80/rtc/mc146818rtc.c M src/drivers/pc80/rtc/mc146818rtc_boot.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/44097/1
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index d58a999..21d3c00 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -6,7 +6,6 @@ #include <fallback.h> #include <version.h> #include <console/console.h> -#include <option.h> #include <pc80/mc146818rtc.h> #include <rtc.h> #include <security/vboot/vbnv.h> diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index fbcf387..550a602 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <console/console.h> -#include <option.h> #include <pc80/mc146818rtc.h> #include <fallback.h>
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c index 923e379..60a1b01 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <option.h> #include <console/console.h> #include <cbfs.h> #include <northbridge/intel/sandybridge/raminit_native.h>
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44097 )
Change subject: src: Remove unused '<option.h>' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44097 )
Change subject: src: Remove unused '<option.h>' ......................................................................
src: Remove unused '<option.h>'
Change-Id: Icb79d60e9ec70a0780d5231698b88cff1db72c9b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44097 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/drivers/pc80/rtc/mc146818rtc.c M src/drivers/pc80/rtc/mc146818rtc_boot.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index d58a999..21d3c00 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -6,7 +6,6 @@ #include <fallback.h> #include <version.h> #include <console/console.h> -#include <option.h> #include <pc80/mc146818rtc.h> #include <rtc.h> #include <security/vboot/vbnv.h> diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index fbcf387..550a602 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <console/console.h> -#include <option.h> #include <pc80/mc146818rtc.h> #include <fallback.h>
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c index 923e379..60a1b01 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <option.h> #include <console/console.h> #include <cbfs.h> #include <northbridge/intel/sandybridge/raminit_native.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)