Hello Andrew McRae,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44206
to review the following change.
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
mainboard/google/puff: Remove second temp sensor
Newer boards have removed the second temperature sensor and relocated the remaining sensor.
Change-Id: Ie41a57598b0c87a6632f4c55c0f60a94a89cae43 Signed-off-by: Andrew McRae amcrae@google.com --- M src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl M src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl 2 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/44206/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl b/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl index 86bd8fc..e0df9ba 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl @@ -19,16 +19,6 @@ #define DPTF_TSR0_ACTIVE_AC3 42 #define DPTF_TSR0_ACTIVE_AC4 39
-#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" -#define DPTF_TSR1_PASSIVE 65 -#define DPTF_TSR1_CRITICAL 75 -#define DPTF_TSR1_ACTIVE_AC0 50 -#define DPTF_TSR1_ACTIVE_AC1 47 -#define DPTF_TSR1_ACTIVE_AC2 45 -#define DPTF_TSR1_ACTIVE_AC3 42 -#define DPTF_TSR1_ACTIVE_AC4 39 - #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -74,10 +64,6 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR0, 95, 85, 75, 65, 55, 45, 0, 0, 0, 0, 0 - }, - Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR1, 95, 85, 75, 65, 55, 45, 0, 0, - 0, 0, 0 } })
@@ -87,9 +73,6 @@
/* CPU Throttle Effect on Ambient (TSR0) */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, - - /* Charger Throttle Effect on Charger (TSR1) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package () diff --git a/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl index 2a94f94..40bc664 100644 --- a/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl @@ -8,11 +8,6 @@ #define DPTF_TSR0_PASSIVE 60 #define DPTF_TSR0_CRITICAL 85
-#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" -#define DPTF_TSR1_PASSIVE 60 -#define DPTF_TSR1_CRITICAL 85 - #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -58,10 +53,6 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR0, 95, 85, 75, 65, 55, 45, 0, 0, 0, 0, 0 - }, - Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR1, 95, 85, 75, 65, 55, 45, 0, 0, - 0, 0, 0 } })
@@ -71,9 +62,6 @@
/* CPU Throttle Effect on Ambient (TSR0) */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, - - /* Charger Throttle Effect on Charger (TSR1) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package ()
Hello Edward O'Callaghan, Andrew McRae,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44206
to look at the new patch set (#2).
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
mainboard/google/puff: Remove second temp sensor
Newer boards have removed the second temperature sensor and relocated the remaining sensor.
BUG=b:162909373 TEST=Confirm on hardware.
Change-Id: Ie41a57598b0c87a6632f4c55c0f60a94a89cae43 Signed-off-by: Andrew McRae amcrae@google.com --- M src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl M src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl 2 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/44206/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44206 )
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
Patch Set 2: Code-Review+1
a
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44206 )
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44206 )
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44206 )
Change subject: mainboard/google/puff: Remove second temp sensor ......................................................................
mainboard/google/puff: Remove second temp sensor
Newer boards have removed the second temperature sensor and relocated the remaining sensor.
BUG=b:162909373 TEST=Confirm on hardware.
Change-Id: Ie41a57598b0c87a6632f4c55c0f60a94a89cae43 Signed-off-by: Andrew McRae amcrae@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44206 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl M src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl 2 files changed, 0 insertions(+), 29 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl b/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl index 86bd8fc..e0df9ba 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/baseboard/include/puff/acpi/dptf.asl @@ -19,16 +19,6 @@ #define DPTF_TSR0_ACTIVE_AC3 42 #define DPTF_TSR0_ACTIVE_AC4 39
-#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" -#define DPTF_TSR1_PASSIVE 65 -#define DPTF_TSR1_CRITICAL 75 -#define DPTF_TSR1_ACTIVE_AC0 50 -#define DPTF_TSR1_ACTIVE_AC1 47 -#define DPTF_TSR1_ACTIVE_AC2 45 -#define DPTF_TSR1_ACTIVE_AC3 42 -#define DPTF_TSR1_ACTIVE_AC4 39 - #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -74,10 +64,6 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR0, 95, 85, 75, 65, 55, 45, 0, 0, 0, 0, 0 - }, - Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR1, 95, 85, 75, 65, 55, 45, 0, 0, - 0, 0, 0 } })
@@ -87,9 +73,6 @@
/* CPU Throttle Effect on Ambient (TSR0) */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, - - /* Charger Throttle Effect on Charger (TSR1) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package () diff --git a/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl index 2a94f94..40bc664 100644 --- a/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/faffy/include/variant/acpi/dptf.asl @@ -8,11 +8,6 @@ #define DPTF_TSR0_PASSIVE 60 #define DPTF_TSR0_CRITICAL 85
-#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" -#define DPTF_TSR1_PASSIVE 60 -#define DPTF_TSR1_CRITICAL 85 - #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -58,10 +53,6 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR0, 95, 85, 75, 65, 55, 45, 0, 0, 0, 0, 0 - }, - Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR1, 95, 85, 75, 65, 55, 45, 0, 0, - 0, 0, 0 } })
@@ -71,9 +62,6 @@
/* CPU Throttle Effect on Ambient (TSR0) */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, - - /* Charger Throttle Effect on Charger (TSR1) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package ()
-
Andrew McRae (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)