Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Patrick Rudolph, Shuo Liu, Subrata Banik, Tim Wawrzynczak, yuchi.chen@intel.com.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85226?usp=email )
Change subject: arch/x86: Enable support for IOAPIC devices
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/85226/comment/c78748e9_291716be?usp... :
PS4, Line 205: path.type = DEVICE_PATH_IOAPIC;
: path.ioapic.ioapic_id = get_ioapic_id(ioapic_base);
: path.ioapic.addr = ioapic_base;
: path.ioapic.gsi_base = gsi_base;
nit: why not:
```suggestion
struct device_path path = {
.type = DEVICE_PATH_IOAPIC,
.ioapic = {
.addr = ioapic_base,
.ioapic_id = get_ioapic_id(ioapic_base), .gsi_base = gsi_base,
}
};
```
File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/85226/comment/ca67a3d7_33f32948?usp... :
PS4, Line 158: printk(BIOS_ERR, "Unknown device type: %d\n", path1->type);
For another patch: this should be an assertion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie13d4f5c4f0704f0935974f90e5b7cf24e94aab3
Gerrit-Change-Number: 85226
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Wed, 04 Dec 2024 11:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes