Attention is currently required from: Raul Rangel, Furquan Shaikh, Paul Menzel, Matt Papageorge, Felix Held.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51806 )
Change subject: [WIP] vc/amd/fsp/cezanne: update UPD headers
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/51806/comment/1b2ce623_9fc7bb17
PS3, Line 13: TODO: move vbios_buffer and gop_reserved back to UPD-S and put back the
Can we remove this? We ended up using the standard VBIOS location.
I would like to keep it if possible for two reasons. #1 it gives us flexibility to relocate it in the future. #2 currently it is used to communicated from CB to FSP that GOP driver is not used (if it is set to NULL).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idca235029bf2e68d403230d55308820cab61a6c0
Gerrit-Change-Number: 51806
Gerrit-PatchSet: 3
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 29 Mar 2021 16:32:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment