Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
......................................................................
Patch Set 13:
(2 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/70773/comment/f336b023_e8078796
PS12, Line 336: config CR50_RESET_CLEAR_EC_AP_IDLE_FLAG
this should move to common code.
+2
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/ff63aaf9_7030e132
PS13, Line 159: if (CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) {
: /* Send EC command to clear AP_IDLE flag */
: if (!google_chromeec_reboot(0, EC_REBOOT_NO_OP,
: EC_REBOOT_FLAG_CLEAR_AP_IDLE |
: EC_REBOOT_FLAG_ON_AP_SHUTDOWN))
: printk(BIOS_INFO,
: "Successfully clear AP_IDLE flag");
: else
: printk(BIOS_ERR,
: "Failed to clear EC AP_IDLE flag");
: }
suggestion: please create a helper function
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 13
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 07:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment