Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52801 )
Change subject: mb/google/guybrush: Fix S0i3/S3 GPIO configuration ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52801/comment/674e3460_5f0f6053 PS1, Line 20: PAD_SCI
I think we need to set this to PAD_GPI instead and make it so the kernel driver can set the wake b […]
I've left it as PAD_WAKE for now. I can do more testing once the wake kernel patch lands.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52801/comment/61bd4737_21aee4c0 PS3, Line 40: SOC_SAR_INT_L
Is this really a wake source? Probably just a PAD_GPI is okay here?
I got the list from b/186011392#12.