Change in coreboot[master]: soc/intel/common, mb/google, mb/siemens: Use lower case x for RXD
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28924 )
Change subject: soc/intel/common, mb/google, mb/siemens: Use lower case x for RXD ......................................................................
Patch Set 2:
(12 comments)
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/gpio.c:
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 147: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 204: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 246: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 149: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 205: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 226: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, Tx1RxDCRx0, DISPUPD), /* AVS_I2S1_MCLK -- LTE_OFF_ODL */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 247: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bip/gpio.c:
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 147: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 204: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/octopus/variant... PS2, Line 246: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/reef/variants/b... File src/mainboard/google/reef/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/reef/variants/b... PS2, Line 330: PAD_CFG_NF_IOSSTATE(GPIO_47, NATIVE, DEEP, NF1, Tx1RxDCRx0), /* LPSS_UART2_TXD */ line over 80 characters
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/reef/variants/c... File src/mainboard/google/reef/variants/coral/gpio.c:
https://review.coreboot.org/#/c/28924/2/src/mainboard/google/reef/variants/c... PS2, Line 330: PAD_CFG_NF_IOSSTATE(GPIO_47, NATIVE, DEEP, NF1, Tx1RxDCRx0), /* LPSS_UART2_TXD */ line over 80 characters
-
build bot (Jenkins) (Code Review)