Change in coreboot[master]: mb/google/skyrim: Add ACPI _PLD custom values

[Won Chung (Code Review)]

Won Chung has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64875 )

Change subject: mb/google/skyrim: Add ACPI _PLD custom values
......................................................................

mb/google/skyrim: Add ACPI _PLD custom values

This patch uses ACPI _PLD macros to add custom values for USB ports.

+----------------+
   |                |
   |     Screen     |
   |                |
   +----------------+
C0 |                | C1
A0 | MLB         DB |
   |                |
   +----------------+

BUG=b:232298017
TEST=emerge-brya coreboot

Signed-off-by: Won Chung 
Change-Id: Idca3dd468f1b9fde37a1bbf20d65768032c7160b
---
M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
M src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
2 files changed, 12 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/64875/1

diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
index 8b0ec3f..1d7c365 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
@@ -80,13 +80,15 @@
    					chip drivers/usb/acpi
    						register "desc" = ""USB3 Type-C Port C0 (MLB)""
    						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
-							register "group" = "ACPI_PLD_GROUP(1, 1)"
+							register "use_custom_pld" = "true"
+							register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
    						device ref usb3_port0 on end
    					end
    					chip drivers/usb/acpi
    						register "desc" = ""USB2 Type-C Port C0 (MLB)""
    						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
-							register "group" = "ACPI_PLD_GROUP(1, 1)"
+                                                        register "use_custom_pld" = "true"
+                                                        register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
    						device ref usb2_port0 on end
    					end
    					chip drivers/usb/acpi
@@ -103,13 +105,15 @@
    					chip drivers/usb/acpi
    						register "desc" = ""USB3 Type-C Port C1 (DB)""
    						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
-							register "group" = "ACPI_PLD_GROUP(2, 1)"
+                                                        register "use_custom_pld" = "true"
+                                                        register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(2, 1))"
    						device ref usb3_port2 on end
    					end
    					chip drivers/usb/acpi
    						register "desc" = ""USB2 Type-C Port C1 (DB)""
    						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
-							register "group" = "ACPI_PLD_GROUP(2, 1)"
+                                                        register "use_custom_pld" = "true"
+                                                        register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(2, 1))"
    						device ref usb2_port2 on end
    					end
    					chip drivers/usb/acpi
diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
index b61945a..b9061ce 100644
--- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
+++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
@@ -42,7 +42,8 @@
    									chip drivers/usb/acpi
    										register "desc" = ""USB3 Type-A Port A0 (DB)""
    										register "type" = "UPC_TYPE_USB3_A"
-											register "group" = "ACPI_PLD_GROUP(2, 2)"
+											register "use_custom_pld" = "true"
+											register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))"
    										device usb 3.0 on end
    									end
    									chip drivers/usb/acpi
@@ -70,7 +71,8 @@
    									chip drivers/usb/acpi
    										register "desc" = ""USB2 Type-A Port A0 (DB)""
    										register "type" = "UPC_TYPE_USB3_A"
-											register "group" = "ACPI_PLD_GROUP(2, 2)"
+											register "use_custom_pld" = "true"
+											register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))"
    										device usb 2.0 on end
    									end
    									chip drivers/usb/acpi