Change in ...coreboot[master]: mb/*/*/romstage: curly braces after the function definition

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31268

Change subject: mb/*/*/romstage: curly braces after the function definition
......................................................................

mb/*/*/romstage: curly braces after the function definition

See Documentation/coding_style.md, specifically "Placing Braces and
Spaces" section.

Change-Id: Ia6a2f3d3547c16500996260b0ece9ec693f00113
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
M src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
M src/mainboard/google/butterfly/romstage.c
M src/mainboard/google/link/romstage.c
M src/mainboard/google/parrot/romstage.c
M src/mainboard/intel/emeraldlake2/romstage.c
M src/mainboard/kontron/ktqm77/romstage.c
M src/mainboard/lenovo/t420s/romstage.c
M src/mainboard/lenovo/x230/romstage.c
9 files changed, 24 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/31268/1

diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
index 543e765..dbb015d 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
@@ -86,7 +86,8 @@
    { 1, 5, 6 },
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[1], 0x51, id_only);
    read_spd (&spd[2], 0x52, id_only);
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
index 1ca6551..89f475e 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
@@ -87,14 +87,16 @@
 };

/* FIXME: This board only has two DIMM slots! */
-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[1], 0x51, id_only);
    read_spd (&spd[2], 0x52, id_only);
    read_spd (&spd[3], 0x53, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)
diff --git a/src/mainboard/google/butterfly/romstage.c b/src/mainboard/google/butterfly/romstage.c
index bfee526..0166997 100644
--- a/src/mainboard/google/butterfly/romstage.c
+++ b/src/mainboard/google/butterfly/romstage.c
@@ -116,12 +116,14 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)
diff --git a/src/mainboard/google/link/romstage.c b/src/mainboard/google/link/romstage.c
index dab4995..91f8297 100644
--- a/src/mainboard/google/link/romstage.c
+++ b/src/mainboard/google/link/romstage.c
@@ -195,7 +195,8 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    memcpy(&spd[0], locate_spd(), 128);
 }

diff --git a/src/mainboard/google/parrot/romstage.c b/src/mainboard/google/parrot/romstage.c
index dd21dcd..186d16d 100644
--- a/src/mainboard/google/parrot/romstage.c
+++ b/src/mainboard/google/parrot/romstage.c
@@ -169,7 +169,8 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c
index d5b6174..b43a9b0 100644
--- a/src/mainboard/intel/emeraldlake2/romstage.c
+++ b/src/mainboard/intel/emeraldlake2/romstage.c
@@ -159,7 +159,8 @@
    { 1, 0, 5 }, /* P13: Back port  (OC5) */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c
index cd6f3b9..9083764 100644
--- a/src/mainboard/kontron/ktqm77/romstage.c
+++ b/src/mainboard/kontron/ktqm77/romstage.c
@@ -156,7 +156,8 @@
    { 1, 0, 4 }, /* P13: internal USB 2.0 (OC4) */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/lenovo/t420s/romstage.c b/src/mainboard/lenovo/t420s/romstage.c
index 49a9b4e..5754a6d 100644
--- a/src/mainboard/lenovo/t420s/romstage.c
+++ b/src/mainboard/lenovo/t420s/romstage.c
@@ -85,7 +85,8 @@
    { 1, 1, -1 }, /* P13: camera (LCD), no OC */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x51, id_only);
 }
diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c
index ba8baa8..6a47ac0 100644
--- a/src/mainboard/lenovo/x230/romstage.c
+++ b/src/mainboard/lenovo/x230/romstage.c
@@ -63,12 +63,14 @@
    { 1, 1, -1 }, /* P13: webcam, no OC */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[2], 0x51, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31268 )

Change subject: mb/*/*/romstage: curly braces after the function definition
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31268 )

Change subject: mb/*/*/romstage: curly braces after the function definition
......................................................................

mb/*/*/romstage: curly braces after the function definition

See Documentation/coding_style.md, specifically "Placing Braces and
Spaces" section.

Change-Id: Ia6a2f3d3547c16500996260b0ece9ec693f00113
Signed-off-by: Peter Lemenkov 
Reviewed-on: https://review.coreboot.org/c/31268
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
M src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
M src/mainboard/google/butterfly/romstage.c
M src/mainboard/google/link/romstage.c
M src/mainboard/google/parrot/romstage.c
M src/mainboard/intel/emeraldlake2/romstage.c
M src/mainboard/kontron/ktqm77/romstage.c
M src/mainboard/lenovo/t420s/romstage.c
M src/mainboard/lenovo/x230/romstage.c
9 files changed, 24 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
index 543e765..dbb015d 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c
@@ -86,7 +86,8 @@
    { 1, 5, 6 },
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[1], 0x51, id_only);
    read_spd (&spd[2], 0x52, id_only);
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
index 1ca6551..89f475e 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c
@@ -87,14 +87,16 @@
 };

/* FIXME: This board only has two DIMM slots! */
-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[1], 0x51, id_only);
    read_spd (&spd[2], 0x52, id_only);
    read_spd (&spd[3], 0x53, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)
diff --git a/src/mainboard/google/butterfly/romstage.c b/src/mainboard/google/butterfly/romstage.c
index bfee526..0166997 100644
--- a/src/mainboard/google/butterfly/romstage.c
+++ b/src/mainboard/google/butterfly/romstage.c
@@ -116,12 +116,14 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)
diff --git a/src/mainboard/google/link/romstage.c b/src/mainboard/google/link/romstage.c
index dab4995..91f8297 100644
--- a/src/mainboard/google/link/romstage.c
+++ b/src/mainboard/google/link/romstage.c
@@ -195,7 +195,8 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    memcpy(&spd[0], locate_spd(), 128);
 }

diff --git a/src/mainboard/google/parrot/romstage.c b/src/mainboard/google/parrot/romstage.c
index dd21dcd..186d16d 100644
--- a/src/mainboard/google/parrot/romstage.c
+++ b/src/mainboard/google/parrot/romstage.c
@@ -169,7 +169,8 @@
    { 0, 0, -1 }, /* P13: Empty */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c
index d5b6174..b43a9b0 100644
--- a/src/mainboard/intel/emeraldlake2/romstage.c
+++ b/src/mainboard/intel/emeraldlake2/romstage.c
@@ -159,7 +159,8 @@
    { 1, 0, 5 }, /* P13: Back port  (OC5) */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c
index cd6f3b9..9083764 100644
--- a/src/mainboard/kontron/ktqm77/romstage.c
+++ b/src/mainboard/kontron/ktqm77/romstage.c
@@ -156,7 +156,8 @@
    { 1, 0, 4 }, /* P13: internal USB 2.0 (OC4) */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x52, id_only);
 }
diff --git a/src/mainboard/lenovo/t420s/romstage.c b/src/mainboard/lenovo/t420s/romstage.c
index 49a9b4e..5754a6d 100644
--- a/src/mainboard/lenovo/t420s/romstage.c
+++ b/src/mainboard/lenovo/t420s/romstage.c
@@ -85,7 +85,8 @@
    { 1, 1, -1 }, /* P13: camera (LCD), no OC */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd(&spd[0], 0x50, id_only);
    read_spd(&spd[2], 0x51, id_only);
 }
diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c
index ba8baa8..6a47ac0 100644
--- a/src/mainboard/lenovo/x230/romstage.c
+++ b/src/mainboard/lenovo/x230/romstage.c
@@ -63,12 +63,14 @@
    { 1, 1, -1 }, /* P13: webcam, no OC */
 };

-void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
+void mainboard_get_spd(spd_raw_data *spd, bool id_only)
+{
    read_spd (&spd[0], 0x50, id_only);
    read_spd (&spd[2], 0x51, id_only);
 }

-void mainboard_early_init(int s3resume) {
+void mainboard_early_init(int s3resume)
+{
 }

void mainboard_config_superio(void)