Attention is currently required from: Damien Zammit, Angel Pons.
Fabio Aiuto has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68103 )
Change subject: treewide: use predicate to check if pci device is on n-th bus
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
thanks for review
File src/mainboard/emulation/qemu-i440fx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/68103/comment/d1e242d5_51bd14aa
PS2, Line 222: if (!is_pci_dev_on_bus(dev, 0))
This is equivalent to: […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a3e96381c29056de71953ea2c39cd540f3df191
Gerrit-Change-Number: 68103
Gerrit-PatchSet: 3
Gerrit-Owner: Fabio Aiuto
fabioaiuto83@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment