Attention is currently required from: Fei Yan, Hung-Te Lin.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email )
Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82076/comment/23b2aaee_937c6984 : PS4, Line 11: NO_PROTECTION -> SEC_RW_ONLY from NO_PROTECTION to SEC_RW_ONLY
File src/soc/mediatek/mt8188/devapc.c:
https://review.coreboot.org/c/coreboot/+/82076/comment/e039eb8a_465bc14d : PS4, Line 1787: protected protection mode ?
https://review.coreboot.org/c/coreboot/+/82076/comment/01905fe0_2a7fa6ff : PS4, Line 1789: 0 Please define this offset. For example: MAS_DOM_1, SCP_DOM0.
File src/soc/mediatek/mt8188/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/82076/comment/b61b9ace_711deb7d : PS4, Line 52: MFG_NS_DOM Use the lowercase. Is the naming correct ? It looks like you have both secure and non-secure values.