Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Create Mudada variant ......................................................................
mb/google/volteer: Create Mudada variant
Create the Mudada variant of the volteer.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/mudada/Makefile.inc A src/mainboard/google/volteer/variants/mudada/gpio.c A src/mainboard/google/volteer/variants/mudada/include/variant/acpi/dptf.asl A src/mainboard/google/volteer/variants/mudada/include/variant/ec.h A src/mainboard/google/volteer/variants/mudada/include/variant/gpio.h A src/mainboard/google/volteer/variants/mudada/memory.c A src/mainboard/google/volteer/variants/mudada/memory/Makefile.inc A src/mainboard/google/volteer/variants/mudada/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/mudada/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/mudada/overridetree.cb 12 files changed, 650 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/1
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 99a08a3..4092c5a 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -68,6 +68,7 @@ string default "Halvor" if BOARD_GOOGLE_HALVOR default "Malefor" if BOARD_GOOGLE_MALEFOR + default "Mudada" if BOARD_GOOGLE_MUDADA default "Ripto" if BOARD_GOOGLE_RIPTO default "Terrador" if BOARD_GOOGLE_TERRADOR default "Trondo" if BOARD_GOOGLE_TRONDO @@ -100,6 +101,7 @@ string default "halvor" if BOARD_GOOGLE_HALVOR default "malefor" if BOARD_GOOGLE_MALEFOR + default "mudada" if BOARD_GOOGLE_MUDADA default "ripto" if BOARD_GOOGLE_RIPTO default "terrador" if BOARD_GOOGLE_TERRADOR default "trondo" if BOARD_GOOGLE_TRONDO diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 6920aaf..a680735 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -8,6 +8,10 @@ bool "-> Malefor" select BOARD_GOOGLE_BASEBOARD_VOLTEER
+config BOARD_GOOGLE_MUDADA + bool "-> Mudada" + select BOARD_GOOGLE_BASEBOARD_VOLTEER + config BOARD_GOOGLE_RIPTO bool "-> Ripto" select BOARD_GOOGLE_BASEBOARD_VOLTEER diff --git a/src/mainboard/google/volteer/variants/mudada/Makefile.inc b/src/mainboard/google/volteer/variants/mudada/Makefile.inc new file mode 100644 index 0000000..343c7db --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/Makefile.inc @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only + +romstage-y += memory.c + +bootblock-y += gpio.c + +ramstage-y += gpio.c diff --git a/src/mainboard/google/volteer/variants/mudada/gpio.c b/src/mainboard/google/volteer/variants/mudada/gpio.c new file mode 100644 index 0000000..0e33926 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/gpio.c @@ -0,0 +1,438 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> + +/* Pad configuration in ramstage */ +/* Leave eSPI pins untouched from default settings */ +static const struct pad_config gpio_table[] = { + /* A0 thru A6 come configured out of reset, do not touch */ + /* A0 : ESPI_IO0 ==> ESPI_IO_0 */ + /* A1 : ESPI_IO1 ==> ESPI_IO_1 */ + /* A2 : ESPI_IO2 ==> ESPI_IO_2 */ + /* A3 : ESPI_IO3 ==> ESPI_IO_3 */ + /* A4 : ESPI_CS# ==> ESPI_CS_L */ + /* A5 : ESPI_CLK ==> ESPI_CLK */ + /* A6 : ESPI_RESET# ==> NC(TP764) */ + /* A7 : I2S2_SCLK ==> EN_PP3300_TRACKPAD */ + PAD_CFG_GPO(GPP_A7, 1, DEEP), + /* A8 : I2S2_SFRM ==> EN_PP3300_TOUCHSCREEN */ + PAD_CFG_GPO(GPP_A8, 0, DEEP), + /* A9 : I2S2_TXD ==> EC_IN_RW_OD */ + PAD_CFG_GPI(GPP_A9, NONE, DEEP), + /* A10 : I2S2_RXD ==> EN_SPKR_PA */ + PAD_CFG_GPO(GPP_A10, 1, DEEP), + /* A11 : PMC_I2C_SDA ==> SSD_PERST_L */ + PAD_CFG_GPO(GPP_A11, 1, DEEP), + /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ + PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), + /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), + /* A14 : USB_OC1# ==> USB_A0_OC_ODL */ + PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), + /* A15 : USB_OC2# ==> USB_A1_OC_ODL */ + PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1), + /* A16 : USB_OC3# ==> USB_C0_OC_ODL */ + PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), + /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ + PAD_CFG_GPI(GPP_A17, NONE, DEEP), + /* A18 : DDSP_HPDB ==> HDMI_HPD */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), + /* A19 : DDSP_HPD1 ==> USB_C0_DP_HPD */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), + /* A20 : DDSP_HPD2 ==> USB_C1_DP_HPD */ + PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), + /* A21 : DDPC_CTRCLK ==> NC */ + PAD_NC(GPP_A21, NONE), + /* A22 : DDPC_CTRLDATA ==> EN_HDMI_PWR */ + PAD_CFG_GPO(GPP_A22, 1, DEEP), + /* A23 : I2S1_SCLK ==> I2S1_SPKR_SCLK */ + PAD_CFG_NF(GPP_A23, NONE, DEEP, NF1), + + /* B0 : CORE_VID0 */ + PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), + /* B1 : CORE_VID1 */ + PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), + /* B2 : VRALERT# ==> NC */ + PAD_NC(GPP_B2, NONE), + /* B3 : CPU_GP2 ==> NC */ + PAD_NC(GPP_B3, NONE), + /* B4 : CPU_GP3 ==> NC */ + PAD_NC(GPP_B4, NONE), + /* B5 : ISH_I2C0_CVF_SDA == NC */ + PAD_NC(GPP_B5, NONE), + /* B6 : ISH_I2C0_CVF_SCL == NC */ + PAD_NC(GPP_B6, NONE), + /* B7 : ISH_12C1_SDA ==> NC */ + PAD_NC(GPP_B7, NONE), + /* B8 : ISH_I2C1_SCL ==> NC */ + PAD_NC(GPP_B8, NONE), + /* B9 : I2C5_SDA ==> PCH_I2C5_TRACKPAD_SDA */ + PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), + /* B10 : I2C5_SCL ==> PCH_I2C5_TRACKPAD_SCL */ + PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), + /* B11 : PMCALERT# ==> PCH_WP_OD */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), + /* B12 : SLP_S0# ==> SLP_S0_L */ + PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + /* B13 : PLTRST# ==> PLT_RST_L */ + PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), + /* B14 : SPKR ==> GPP_B14_STRAP */ + PAD_NC(GPP_B14, NONE), + /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ + PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), + /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ + PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), + /* B17 : GSPI0_MISO ==> PCH_GSPIO_H1_TPM_MISO */ + PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), + /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ + PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), + /* B19 : GSPI1_CS0# ==> NC */ + PAD_NC(GPP_B19, NONE), + /* B20 : GSPI1_CLK ==> NC */ + PAD_NC(GPP_B20, NONE), + /* B21 : GSPI1_MISO ==> NC */ + PAD_NC(GPP_B21, NONE), + /* B22 : GSPI1_MOSI ==> NC */ + PAD_NC(GPP_B22, NONE), + /* B23 : SML1ALERT# ==> GPP_B23_STRAP # */ + PAD_NC(GPP_B23, NONE), + + /* C0 : SMBCLK ==> EN_PP3300_WLAN */ + PAD_CFG_GPO(GPP_C0, 1, DEEP), + /* C1 : SMBDATA ==> NOT USED */ + PAD_NC(GPP_C1, NONE), + /* C2 : SMBALERT# ==> GPP_C2_STRAP */ + PAD_NC(GPP_C2, NONE), + /* C3 : SML0CLK ==> NC */ + PAD_NC(GPP_C3, NONE), + /* C4 : SML0DATA ==> NC */ + PAD_NC(GPP_C4, NONE), + /* C5 : SML0ALERT# ==> USB_SMB_INT_L_BOOT_STRAP0 */ + PAD_NC(GPP_C5, NONE), + /* C6 : SML1CLK ==> EC_PCH_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_C6, NONE, PLTRST, LEVEL, INVERT), + /* C7 : SML1DATA ==> NC */ + PAD_NC(GPP_C7, NONE), + /* C8 : UART0_RXD ==> UART_PCH_RX_DEBUG_TX */ + PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), + /* C9 : UART0_TXD ==> UART_PCH_TX_DEBUG_RX */ + PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), + /* C10 : UART0_RTS# ==> USI_RST_L */ + PAD_CFG_GPO(GPP_C10, 0, DEEP), + /* C11 : UART0_CTS# ==> NC */ + PAD_NC(GPP_C11, NONE), + /* C12 : UART1_RXD ==> MEM_STRAP_0 */ + PAD_CFG_GPI(GPP_C12, NONE, DEEP), + /* C13 : UART1_TXD ==> NC */ + PAD_NC(GPP_C13, NONE), + /* C14 : UART1_RTS# ==> MEM_STRAP_2 */ + PAD_CFG_GPI(GPP_C14, NONE, DEEP), + /* C15 : UART1_CTS# ==> MEM_STRAP_1 */ + PAD_CFG_GPI(GPP_C15, NONE, DEEP), + /* C16 : I2C0_SDA ==> PCH_I2C0_1V8_AUDIO_SDA */ + PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), + /* C17 : I2C0_SCL ==> PCH_I2C0_1V8_AUDIO_SCL */ + PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), + /* C18 : I2C1_SDA ==> PCH_I2C1_TOUCH_USI_SDA */ + PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), + /* C19 : I2C1_SCL ==> PCH_I2C1_TOUCH_USI_SCL */ + PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), + /* C20 : UART2_RXD ==> NC */ + PAD_NC(GPP_C20, NONE), + /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), + /* C22 : UART2_RTS# ==> NC */ + PAD_NC(GPP_C22, NONE), + /* C23 : UART2_CTS# ==> NC */ + PAD_NC(GPP_C23, NONE), + + /* D0 : ISH_GP0 ==> NC */ + PAD_NC(GPP_D0, NONE), + /* D1 : ISH_GP1 ==> NC */ + PAD_NC(GPP_D1, NONE), + /* D2 : ISH_GP2 ==> NC */ + PAD_NC(GPP_D2, NONE), + /* D3 : ISH_GP3 ==> NC */ + PAD_NC(GPP_D3, NONE), + /* D4 : IMGCLKOUT0 ==> NC */ + PAD_NC(GPP_D4, NONE), + /* D5 : SRCCLKREQ0$ ==> SSD_CLKREQ_ODL */ + PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), + /* D6 : SRCCLKREQ1# ==> NC */ + PAD_NC(GPP_D6, NONE), + /* D7 : SRCCLKREQ2# ==> NC */ + PAD_NC(GPP_D7, NONE), + /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ + PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), + /* D9 : ISH_SPI_CS# ==> NC */ + PAD_NC(GPP_D9, NONE), + /* D10 : ISH_SPI_CLK ==> PCH_GSPI2_CVF_CLK_STRAP */ + PAD_CFG_NF(GPP_D10, NONE, DEEP, NF7), + /* D11 : ISH_SPI_MISO ==> NC */ + PAD_NC(GPP_D11, NONE), + /* D12 : ISH_SPI_MOSI ==> PCH_GSPI2_CVF_MISO_STRAP */ + PAD_CFG_NF(GPP_D12, DN_20K, DEEP, NF7), + /* D13 : ISH_UART0_RXD ==> UART_ISH_RX_DEBUG_TX */ + PAD_CFG_NF(GPP_D13, NONE, DEEP, NF1), + /* D14 : ISH_UART0_TXD ==> UART_ISH_TX_DEBUG_RX */ + PAD_CFG_NF(GPP_D14, NONE, DEEP, NF1), + /* D15 : ISH_UART0_RTS# ==> MEM_STRAP_3 */ + PAD_CFG_GPI(GPP_D15, NONE, DEEP), + /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* D17 : ISH_GP4 ==> EN_FCAM_PWR */ + PAD_CFG_GPO(GPP_D17, 1, DEEP), + /* D18 : ISH_GP5 ==> NC */ + PAD_NC(GPP_D18, NONE), + /* D19 : I2S_MCLK1 ==> I2S_MCLK1 */ + PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), + + /* E0 : SATAXPCIE0 ==> USB_A1_RT_RST_ODL */ + PAD_CFG_GPO(GPP_E0, 1, DEEP), + /* E1 : SPI1_IO2 ==> NC */ + PAD_NC(GPP_E1, NONE), + /* E2 : SPI1_IO3 ==> NC */ + PAD_NC(GPP_E2, NONE), + /* E3 : CPU_GP0 ==> USI_REPORT_EN */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), + /* E4 : SATA_DEVSLP0 ==> M2_SSD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E4, NONE, DEEP), + /* E5 : SATA_DEVSLP1 ==> M2_SSD_DEVSLP_OD */ + PAD_CFG_NF(GPP_E5, NONE, DEEP, NF1), + /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */ + PAD_NC(GPP_E6, NONE), + /* E7 : CPU_GP1 ==> USI_INT */ + PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE), + /* E8 : SPI1_CS1# ==> SLP_S0IX */ + PAD_CFG_GPO(GPP_E8, 0, DEEP), + /* E9 : USB2_OC0# ==> USB_C1_OC_ODL */ + PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), + /* E10 : SPI1_CS# ==> USB_C0_AUXP_DC */ + PAD_CFG_NF(GPP_E10, NONE, DEEP, NF6), + /* E11 : SPI1_CLK ==> SD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E11, NONE, DEEP), + /* E12 : SPI1_MISO_IO1 ==> NC */ + PAD_NC(GPP_E12, NONE), + /* E13 : SPI1_MOSI_IO0 ==> USB_C0_AUXN_DC */ + PAD_CFG_NF(GPP_E13, NONE, DEEP, NF6), + /* E14 : DDPC_HPDA ==> SOC_EDP_HPD */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), + /* E15 : ISH_GP6 ==> TRACKPAD_INT_ODL */ + PAD_CFG_GPI_IRQ_WAKE(GPP_E15, NONE, DEEP, LEVEL, INVERT), + /* E16 : ISH_GP7 ==> NC */ + PAD_NC(GPP_E16, NONE), + /* E17 : THC0_SPI1_INT# ==> NC */ + PAD_NC(GPP_E17, NONE), + /* E18 : DDP1_CTRLCLK ==> NC */ + PAD_NC(GPP_E18, NONE), + /* E19 : DDP1_CTRLDATA ==> USB0_C0_LSX_SOC_RX_STRAP */ + PAD_CFG_NF(GPP_E19, NONE, DEEP, NF4), + /* E20 : DDP2_CTRLCLK ==> NC */ + PAD_NC(GPP_E20, NONE), + /* E21 : DDP2_CTRLDATA ==> USB_C1_LSX_SOC_RX_STRAP */ + PAD_CFG_NF(GPP_E21, NONE, DEEP, NF4), + /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC: Retimer FW drives this pin */ + PAD_NC(GPP_E22, NONE), + /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC: Retimer FW drives this pin */ + PAD_NC(GPP_E23, NONE), + + /* F0 : CNV_BRI_DT ==> CNV_BRI_DT_STRAP */ + PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), + /* F1 : CNV_BRI_RSP ==> NCV_BRI_RSP */ + PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), + /* F2 : I2S2_TXD ==> CNV_RGI_DT_STRAP */ + PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), + /* F3 : I2S2_RXD ==> CNV_RGI_RSP */ + PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), + /* F4 : CNV_RF_RESET# ==> CNV_RF_RST_L */ + PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), + /* F5 : MODEM_CLKREQ ==> CNV_CLKREQ0 */ + PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3), + /* F6 : CNV_PA_BLANKING ==> NC */ + PAD_NC(GPP_F6, NONE), + /* F7 : GPPF7_STRAP */ + PAD_NC(GPP_F7, NONE), + /* F8 : I2S_MCLK2_INOUT ==> HP_INT_L */ + PAD_CFG_GPI_INT(GPP_F8, NONE, PLTRST, EDGE_BOTH), + /* F9 : Reserved ==> NC */ + PAD_NC(GPP_F9, NONE), + /* F10 : GPPF10_STRAP */ + PAD_NC(GPP_F10, DN_20K), + /* F11 : GPPF11_THC1_SPI2_CLK ==> NC */ + PAD_NC(GPP_F11, NONE), + /* F12 : GSXDOUT ==> NC */ + PAD_NC(GPP_F12, NONE), + /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ + PAD_CFG_GPO(GPP_F13, 1, DEEP), + /* F14 : GSXDIN ==> NC */ + PAD_NC(GPP_F14, NONE), + /* F15 : GSXSRESET# ==> NC */ + PAD_NC(GPP_F15, NONE), + /* F16 : GSXCLK ==> NC */ + PAD_NC(GPP_F16, NONE), + /* F17 : WWAN_RF_DISABLE_ODL == NC */ + PAD_NC(GPP_F17, NONE), + /* F18 : THC1_SPI2_INT# ==> NC */ + PAD_NC(GPP_F18, NONE), + /* F19 : SRCCLKREQ6# ==> NC */ + PAD_NC(GPP_F19, NONE), + /* F20 : EXT_PWR_GATE# ==> EXT_PWR_GATE_L */ + PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), + /* F21 : EXT_PWR_GATE2# ==> EXT_PWR_GATE2_L */ + PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + /* F22 : VNN_CTRL */ + PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1), + /* F23 : V1P05_CTRL */ + PAD_CFG_NF(GPP_F23, NONE, DEEP, NF1), + + /* H0 : GPPH0_BOOT_STRAP1 */ + PAD_NC(GPP_H0, NONE), + /* H1 : GPPH1_BOOT_STRAP2 */ + PAD_NC(GPP_H1, NONE), + /* H2 : GPPH2_BOOT_STRAP3 */ + PAD_NC(GPP_H2, NONE), + /* H3 : SX_EXIT_HOLDOFF# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H3, 1, DEEP), + /* H4 : I2C2_SDA ==> PCH_I2C2_MISC_SDA */ + PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), + /* H5 : I2C2_SCL ==> PCH_I2C2_MISC_SCL */ + PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), + /* H6 : I2C3_SDA ==> NC */ + PAD_NC(GPP_H6, NONE), + /* H7 : I2C3_SCL ==> NC */ + PAD_NC(GPP_H7, NONE), + /* H8 : I2C4_SDA ==> PCB_ID0 */ + PAD_CFG_GPI(GPP_H8, NONE, DEEP), + /* H9 : I2C4_SCL ==> PCB_ID1 */ + PAD_CFG_GPI(GPP_H9, NONE, DEEP), + /* H10 : SRCCLKREQ4# ==> NC */ + PAD_NC(GPP_H10, NONE), + /* H11 : SRCCLKREQ5# ==> NC */ + PAD_NC(GPP_H11, NONE), + /* H12 : M2_SKT2_CFG0 ==> NC */ + PAD_NC(GPP_H12, NONE), + /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */ + PAD_CFG_GPI(GPP_H13, NONE, DEEP), + /* H14 : M2_SKT2_CFG2 # ==> NC */ + PAD_NC(GPP_H14, NONE), + /* H15 : M2_SKT2_CFG3 # ==> NC */ + PAD_NC(GPP_H15, NONE), + /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */ + PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), + /* H17 : DDPB_CTRLDATA ==> DDPB_HDMI_CTRLDATA */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), + /* H18 : CPU_C10_GATE# ==> CPU_C10_GATE_L */ + PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), + /* H19 : TIME_SYNC0 ==> NC */ + PAD_NC(GPP_H19, NONE), + /* H20 : IMGCLKOUT1 ==> NC */ + PAD_NC(GPP_H20, NONE), + /* H21 : IMGCLKOUT2 ==> NC */ + PAD_NC(GPP_H21, NONE), + /* H22 : IMGCLKOUT3 ==> NC */ + PAD_NC(GPP_H22, NONE), + /* H23 : IMGCLKOUT4 ==> NC */ + PAD_NC(GPP_H23, NONE), + + /* R0 : HDA_BCLK ==> I2S0_HP_SCLK */ + PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2), + /* R1 : HDA_SYNC ==> I2S0_HP_SFRM */ + PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), + /* R2 : HDA_SDO ==> I2S0_PCH_TX_HP_RX_STRAP */ + PAD_CFG_NF(GPP_R2, DN_20K, DEEP, NF2), + /* R3 : HDA_SDIO ==> I2S0_PCH_RX_HP_TX */ + PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), + /* R4 : HDA_RST# ==> NC */ + PAD_NC(GPP_R4, NONE), + /* R5 : HDA_SDI1 ==> I2S1_PCH_RX_SPKR_TX */ + PAD_CFG_NF(GPP_R5, NONE, DEEP, NF2), + /* R6 : I2S1_TXD ==> I2S1_PCH_RX_SPKR_RX */ + PAD_CFG_NF(GPP_R6, NONE, DEEP, NF2), + /* R7 : I2S1_SFRM ==> I2S1_SPKR_SFRM */ + PAD_CFG_NF(GPP_R7, NONE, DEEP, NF2), + + /* S0 : SNDW0_CLK ==> SNDW0_HP_CLK */ + PAD_CFG_NF(GPP_S0, NONE, DEEP, NF1), + /* S1 : SNDW0_DATA ==> SNDW0_HP_DATA */ + PAD_CFG_NF(GPP_S1, NONE, DEEP, NF1), + /* S2 : SNDW1_CLK ==> SNDW1_SPKR_CLK */ + PAD_CFG_NF(GPP_S2, NONE, DEEP, NF1), + /* S3 : SNDW1_DATA ==> SNDW1_SPKR_DATA */ + PAD_CFG_NF(GPP_S3, NONE, DEEP, NF1), + /* S4 : SNDW2_CLK ==> NC */ + PAD_NC(GPP_S4, NONE), + /* S5 : SNDW2_DATA ==> NC */ + PAD_NC(GPP_S5, NONE), + /* S6 : SNDW3_CLK ==> DMIC_CLK0 */ + PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), + /* S7 : SNDW3_DATA ==> DMIC_DATA0 */ + PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), + + /* GPD0: BATLOW# ==> BATLOW_L */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), + /* GPD1: ACPRESENT ==> PCH_ACPRESENT */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* GPD2: LAN_WAKE# ==> EC_PCH_WAKE_ODL */ + PAD_CFG_NF(GPD2, NONE, DEEP, NF1), + /* GPD3: PWRBTN# ==> EC_PCH_PWR_BTN_ODL */ + PAD_CFG_NF(GPD3, NONE, DEEP, NF1), + /* GPD4: SLP_S3# ==> SLP_S3_L */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + /* GPD5: SLP_S4# ==> SLP_S4_L */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + /* GPD6: SLP_A# ==> SLP_A_L */ + PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + /* GPD7: GPD7_STRAP */ + PAD_CFG_GPI(GPD7, DN_20K, DEEP), + /* GPD8: SUSCLK ==> PCH_SUSCLK */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), + /* GPD9: SLP_WLAN# ==> SLP_WLAN_L */ + PAD_CFG_NF(GPD9, NONE, DEEP, NF1), + /* GPD10: SLP_S5# ==> SLP_S5_L */ + PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + /* GPD11: LANPHYC ==> NC */ +}; + +/* Early pad configuration in bootblock */ +static const struct pad_config early_gpio_table[] = { + /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ + PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), + + /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ + PAD_CFG_GPI(GPP_A17, NONE, DEEP), + + /* B11 : PMCALERT# ==> PCH_WP_OD */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), + + /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ + PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), + + /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ + PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), + + /* B17 : GSPI0_MISO ==> PCH_GSPIO_H1_TPM_MISO */ + PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), + + /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ + PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), + + /* C0 : SMBCLK ==> EN_PP3300_WLAN */ + PAD_CFG_GPO(GPP_C0, 1, DEEP), + + /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), +}; + +const struct pad_config *variant_override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(gpio_table); + return gpio_table; +} + +const struct pad_config *variant_early_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(early_gpio_table); + return early_gpio_table; +} diff --git a/src/mainboard/google/volteer/variants/mudada/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/mudada/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..726e381 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/include/variant/acpi/dptf.asl @@ -0,0 +1,7 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/mudada/include/variant/ec.h b/src/mainboard/google/volteer/variants/mudada/include/variant/ec.h new file mode 100644 index 0000000..6e12175 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/include/variant/ec.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/mudada/include/variant/gpio.h b/src/mainboard/google/volteer/variants/mudada/include/variant/gpio.h new file mode 100644 index 0000000..c7e4605 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/include/variant/gpio.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/volteer/variants/mudada/memory.c b/src/mainboard/google/volteer/variants/mudada/memory.c new file mode 100644 index 0000000..d0bfcb5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/memory.c @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/variants.h> + +static const struct lpddr4x_cfg malefor_memcfg = { + /* DQ byte map */ + .dq_map = { + [0] = { + { 3, 2, 1, 0, 4, 5, 7, 6, }, /* DDR0_DQ0[7:0] */ + { 12, 13, 14, 15, 11, 10, 9, 8 }, /* DDR0_DQ1[7:0] */ + }, + [1] = { + { 0, 7, 1, 6, 2, 5, 3, 4, }, /* DDR1_DQ0[7:0] */ + { 8, 15, 14, 9, 12, 10, 13, 11 }, /* DDR1_DQ1[7:0] */ + }, + [2] = { + { 2, 3, 0, 1, 4, 5, 6, 7, }, /* DDR2_DQ0[7:0] */ + { 12, 13, 15, 14, 11, 10, 9, 8 }, /* DDR2_DQ1[7:0] */ + }, + [3] = { + { 7, 0, 1, 6, 5, 4, 2, 3, }, /* DDR3_DQ0[7:0] */ + { 15, 14, 8, 9, 10, 13, 11, 12 }, /* DDR3_DQ1[7:0] */ + }, + [4] = { + { 4, 5, 2, 3, 7, 6, 0, 1, }, /* DDR4_DQ0[7:0] */ + { 12, 13, 15, 14, 11, 10, 8, 9 }, /* DDR4_DQ1[7:0] */ + }, + [5] = { + { 3, 4, 2, 5, 0, 6, 1, 7, }, /* DDR5_DQ0[7:0] */ + { 12, 13, 11, 10, 14, 15, 9, 8 }, /* DDR5_DQ1[7:0] */ + }, + [6] = { + { 3, 2, 1, 0, 7, 4, 5, 6, }, /* DDR6_DQ0[7:0] */ + { 15, 14, 13, 12, 8, 9, 10, 11 }, /* DDR6_DQ1[7:0] */ + }, + [7] = { + { 2, 4, 3, 5, 1, 0, 7, 6, }, /* DDR7_DQ0[7:0] */ + { 14, 15, 9, 8, 12, 10, 11, 13 }, /* DDR7_DQ1[7:0] */ + }, + }, + + /* DQS CPU<>DRAM map */ + .dqs_map = { + [0] = { 0, 1 }, /* DDR0_DQS[1:0] */ + [1] = { 0, 1 }, /* DDR1_DQS[1:0] */ + [2] = { 0, 1 }, /* DDR2_DQS[1:0] */ + [3] = { 0, 1 }, /* DDR3_DQS[1:0] */ + [4] = { 0, 1 }, /* DDR4_DQS[1:0] */ + [5] = { 0, 1 }, /* DDR5_DQS[1:0] */ + [6] = { 0, 1 }, /* DDR6_DQS[1:0] */ + [7] = { 0, 1 }, /* DDR7_DQS[1:0] */ + }, + + .ect = 1, /* Enable Early Command Training */ +}; + +const struct lpddr4x_cfg *variant_memory_params(void) +{ + return &malefor_memcfg; +} diff --git a/src/mainboard/google/volteer/variants/mudada/memory/Makefile.inc b/src/mainboard/google/volteer/variants/mudada/memory/Makefile.inc new file mode 100644 index 0000000..7aa547b --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += spd-2.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/volteer/variants/mudada/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/mudada/memory/dram_id.generated.txt new file mode 100644 index 0000000..b5bd3ef --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/memory/dram_id.generated.txt @@ -0,0 +1,5 @@ +DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +H9HCNNNBKMMLXR-NEE 0 (0000) +H9HCNNNCPMMLXR-NEE 2 (0010) diff --git a/src/mainboard/google/volteer/variants/mudada/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/mudada/memory/mem_list_variant.txt new file mode 100644 index 0000000..b99b811 --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/memory/mem_list_variant.txt @@ -0,0 +1,4 @@ +MT53E512M32D2NP-046 WT:E +MT53E1G32D2NP-046 WT:A +H9HCNNNBKMMLXR-NEE +H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/volteer/variants/mudada/overridetree.cb b/src/mainboard/google/volteer/variants/mudada/overridetree.cb new file mode 100644 index 0000000..9e5ef4b --- /dev/null +++ b/src/mainboard/google/volteer/variants/mudada/overridetree.cb @@ -0,0 +1,92 @@ +chip soc/intel/tigerlake + device domain 0 on + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on + probe AUDIO MAX98357_ALC5682I_I2S + probe AUDIO MAX98373_ALC5682I_I2S + end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "0" + register "imon_slot_no" = "1" + register "uid" = "0" + register "desc" = ""Right Speaker Amp"" + register "name" = ""MAXR"" + device i2c 31 on + probe AUDIO MAX98373_ALC5682I_I2S + end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "2" + register "imon_slot_no" = "3" + register "uid" = "1" + register "desc" = ""Left Speaker Amp"" + register "name" = ""MAXL"" + device i2c 32 on + probe AUDIO MAX98373_ALC5682I_I2S + end + end + end + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98357A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" + register "sdmode_delay" = "5" + device generic 0 on + probe AUDIO MAX98357_ALC5682I_I2S + end + end + chip drivers/intel/soundwire + device generic 0 on + probe AUDIO MAX98373_ALC5682_SNDW + chip drivers/soundwire/alc5682 + # SoundWire Link 0 ID 1 + register "desc" = ""Headset Codec"" + device generic 0.1 on end + end + chip drivers/soundwire/max98373 + # SoundWire Link 1 ID 3 + register "desc" = ""Left Speaker Amp"" + device generic 1.3 on end + end + chip drivers/soundwire/max98373 + # SoundWire Link 1 ID 7 + register "desc" = ""Right Speaker Amp"" + device generic 1.7 on end + end + end + end + end + device pci 1f.2 hidden + # The pmc_mux chip driver is a placeholder for the + # PMC.MUX device in the ACPI hierarchy. + chip drivers/intel/pmc_mux + device generic 0 on + chip drivers/intel/pmc_mux/con + register "usb2_port_number" = "9" + register "usb3_port_number" = "1" + # SBU & HSL follow CC + device generic 0 on end + end + chip drivers/intel/pmc_mux/con + register "usb2_port_number" = "4" + register "usb3_port_number" = "2" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 1 on end + end + end + end + end # PMC + end +end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Create Mudada variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG@9 PS1, Line 9: Create the Mudada variant of the volteer. How did you create it? Is it a copy of some existing variant? Run a script?
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Create Mudada variant ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG@9 PS1, Line 9: Create the Mudada variant of the volteer.
How did you create it? Is it a copy of some existing variant? Run a script?
We copy it from volteer folder and modify settings follow mudada design .
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#2).
Change subject: mb/google/volteer: Create Delbin variant ......................................................................
mb/google/volteer: Create Delbin variant
Create the delbin variant of the volteer.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl A src/mainboard/google/volteer/variants/delbin/include/variant/ec.h A src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/delbin/overridetree.cb 12 files changed, 650 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#3).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Add delbin variant of the volteer.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 609 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/3
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/3//COMMIT_MSG@9 PS3, Line 9: Add delbin variant of the volteer. Please describe the change in this patch
Ken Lu has uploaded a new patch set (#4) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO , memory SPD table , audio and USB type C .
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 609 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/4
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/3//COMMIT_MSG@9 PS3, Line 9: Add delbin variant of the volteer.
Please describe the change in this patch
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#5).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, audio and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 667 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#6).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, audio and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 667 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/6
Ken Lu has uploaded a new patch set (#7) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 667 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/7
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 134: con typo 'con' should be 'conn'
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 140: con same as above.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 7:
(49 comments)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 22: /* A9 : I2S2_TXD ==> EC_IN_RW_OD */ : PAD_CFG_GPI(GPP_A9, NONE, DEEP), Remove this because this is same as baseboard/gpio.c
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 26: /* A11 : PMC_I2C_SDA ==> SSD_PERST_L */ : PAD_CFG_GPO(GPP_A11, 1, DEEP), : /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ : PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 32: /* A14 : USB_OC1# ==> USB_A0_OC_ODL */ : PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), : /* A15 : USB_OC2# ==> USB_A1_OC_ODL */ : PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 38: /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ : PAD_CFG_GPI(GPP_A17, NONE, DEEP), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 46: /* A21 : DDPC_CTRCLK ==> NC */ : PAD_NC(GPP_A21, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 53: /* B0 : CORE_VID0 */ : PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), : /* B1 : CORE_VID1 */ : PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 59: /* B3 : CPU_GP2 ==> NC */ : PAD_NC(GPP_B3, NONE), : /* B4 : CPU_GP3 ==> NC */ : PAD_NC(GPP_B4, NONE), : /* B5 : ISH_I2C0_CVF_SDA == NC */ : PAD_NC(GPP_B5, NONE), : /* B6 : ISH_I2C0_CVF_SCL == NC */ : PAD_NC(GPP_B6, NONE), : /* B7 : ISH_12C1_SDA ==> NC */ : PAD_NC(GPP_B7, NONE), : /* B8 : ISH_I2C1_SCL ==> NC */ : PAD_NC(GPP_B8, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 75: /* B11 : PMCALERT# ==> PCH_WP_OD */ : PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), : /* B12 : SLP_S0# ==> SLP_S0_L */ : PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), : /* B13 : PLTRST# ==> PLT_RST_L */ : PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), : /* B14 : SPKR ==> GPP_B14_STRAP */ : PAD_NC(GPP_B14, NONE), : /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ : PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), : /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ : PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), : /* B17 : GSPI0_MISO ==> PCH_GSPIO_H1_TPM_MISO */ : PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), : /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ : PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), : /* B19 : GSPI1_CS0# ==> NC */ : PAD_NC(GPP_B19, NONE), : /* B20 : GSPI1_CLK ==> NC */ : PAD_NC(GPP_B20, NONE), : /* B21 : GSPI1_MISO ==> NC */ : PAD_NC(GPP_B21, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 99: /* B23 : SML1ALERT# ==> GPP_B23_STRAP # */ : PAD_NC(GPP_B23, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 104: /* C1 : SMBDATA ==> NOT USED */ : PAD_NC(GPP_C1, NONE), : /* C2 : SMBALERT# ==> GPP_C2_STRAP */ : PAD_NC(GPP_C2, NONE), : /* C3 : SML0CLK ==> NC */ : PAD_NC(GPP_C3, NONE), : /* C4 : SML0DATA ==> NC */ : PAD_NC(GPP_C4, NONE), : /* C5 : SML0ALERT# ==> USB_SMB_INT_L_BOOT_STRAP0 */ : PAD_NC(GPP_C5, NONE), : /* C6 : SML1CLK ==> EC_PCH_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_C6, NONE, PLTRST, LEVEL, INVERT), : /* C7 : SML1DATA ==> NC */ : PAD_NC(GPP_C7, NONE), : /* C8 : UART0_RXD ==> UART_PCH_RX_DEBUG_TX */ : PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), : /* C9 : UART0_TXD ==> UART_PCH_TX_DEBUG_RX */ : PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 124: /* C11 : UART0_CTS# ==> NC */ : PAD_NC(GPP_C11, NONE), : /* C12 : UART1_RXD ==> MEM_STRAP_0 */ : PAD_CFG_GPI(GPP_C12, NONE, DEEP), : /* C13 : UART1_TXD ==> NC */ : PAD_NC(GPP_C13, NONE), : /* C14 : UART1_RTS# ==> MEM_STRAP_2 */ : PAD_CFG_GPI(GPP_C14, NONE, DEEP), : /* C15 : UART1_CTS# ==> MEM_STRAP_1 */ : PAD_CFG_GPI(GPP_C15, NONE, DEEP), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 142: /* C20 : UART2_RXD ==> NC */ : PAD_NC(GPP_C20, NONE), : /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), : /* C22 : UART2_RTS# ==> NC */ : PAD_NC(GPP_C22, NONE), : /* C23 : UART2_CTS# ==> NC */ : PAD_NC(GPP_C23, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 151: /* D0 : ISH_GP0 ==> NC */ : PAD_NC(GPP_D0, NONE), : /* D1 : ISH_GP1 ==> NC */ : PAD_NC(GPP_D1, NONE), : /* D2 : ISH_GP2 ==> NC */ : PAD_NC(GPP_D2, NONE), : /* D3 : ISH_GP3 ==> NC */ : PAD_NC(GPP_D3, NONE), : /* D4 : IMGCLKOUT0 ==> NC */ : PAD_NC(GPP_D4, NONE), : /* D5 : SRCCLKREQ0$ ==> SSD_CLKREQ_ODL */ : PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), : /* D6 : SRCCLKREQ1# ==> NC */ : PAD_NC(GPP_D6, NONE), : /* D7 : SRCCLKREQ2# ==> NC */ : PAD_NC(GPP_D7, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 169: /* D9 : ISH_SPI_CS# ==> NC */ : PAD_NC(GPP_D9, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 171: /* D10 : ISH_SPI_CLK ==> PCH_GSPI2_CVF_CLK_STRAP */ : PAD_CFG_NF(GPP_D10, NONE, DEEP, NF7), Remove this. The resistors are unstuffed
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 173: /* D11 : ISH_SPI_MISO ==> NC */ : PAD_NC(GPP_D11, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 175: /* D12 : ISH_SPI_MOSI ==> PCH_GSPI2_CVF_MISO_STRAP */ : PAD_CFG_NF(GPP_D12, DN_20K, DEEP, NF7), Remove this. The resistors are unstuffed
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 181: /* D15 : ISH_UART0_RTS# ==> MEM_STRAP_3 */ : PAD_CFG_GPI(GPP_D15, NONE, DEEP), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 187: /* D18 : ISH_GP5 ==> NC */ : PAD_NC(GPP_D18, NONE), : /* D19 : I2S_MCLK1 ==> I2S_MCLK1 */ : PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 192: /* E0 : SATAXPCIE0 ==> USB_A1_RT_RST_ODL */ : PAD_CFG_GPO(GPP_E0, 1, DEEP), : /* E1 : SPI1_IO2 ==> NC */ : PAD_NC(GPP_E1, NONE), : /* E2 : SPI1_IO3 ==> NC */ : PAD_NC(GPP_E2, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 202: /* E5 : SATA_DEVSLP1 ==> M2_SSD_DEVSLP_OD */ : PAD_CFG_NF(GPP_E5, NONE, DEEP, NF1), : /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */ : PAD_NC(GPP_E6, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 210: /* E9 : USB2_OC0# ==> USB_C1_OC_ODL */ : PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), : /* E10 : SPI1_CS# ==> USB_C0_AUXP_DC */ : PAD_CFG_NF(GPP_E10, NONE, DEEP, NF6), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 216: /* E12 : SPI1_MISO_IO1 ==> NC */ : PAD_NC(GPP_E12, NONE), : /* E13 : SPI1_MOSI_IO0 ==> USB_C0_AUXN_DC */ : PAD_CFG_NF(GPP_E13, NONE, DEEP, NF6), : /* E14 : DDPC_HPDA ==> SOC_EDP_HPD */ : PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 224: /* E16 : ISH_GP7 ==> NC */ : PAD_NC(GPP_E16, NONE), : /* E17 : THC0_SPI1_INT# ==> NC */ : PAD_NC(GPP_E17, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 230: /* E19 : DDP1_CTRLDATA ==> USB0_C0_LSX_SOC_RX_STRAP */ : PAD_CFG_NF(GPP_E19, NONE, DEEP, NF4), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 234: /* E21 : DDP2_CTRLDATA ==> USB_C1_LSX_SOC_RX_STRAP */ : PAD_CFG_NF(GPP_E21, NONE, DEEP, NF4), : /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E22, NONE), : /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E23, NONE), : Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 241: /* F0 : CNV_BRI_DT ==> CNV_BRI_DT_STRAP */ : PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), : /* F1 : CNV_BRI_RSP ==> NCV_BRI_RSP */ : PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), : /* F2 : I2S2_TXD ==> CNV_RGI_DT_STRAP */ : PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), : /* F3 : I2S2_RXD ==> CNV_RGI_RSP */ : PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), : /* F4 : CNV_RF_RESET# ==> CNV_RF_RST_L */ : PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), : /* F5 : MODEM_CLKREQ ==> CNV_CLKREQ0 */ : PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3), : /* F6 : CNV_PA_BLANKING ==> NC */ : PAD_NC(GPP_F6, NONE), : /* F7 : GPPF7_STRAP */ : PAD_NC(GPP_F7, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 259: /* F9 : Reserved ==> NC */ : PAD_NC(GPP_F9, NONE), : /* F10 : GPPF10_STRAP */ : PAD_NC(GPP_F10, DN_20K), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 265: /* F12 : GSXDOUT ==> NC */ : PAD_NC(GPP_F12, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 269: /* F14 : GSXDIN ==> NC */ : PAD_NC(GPP_F14, NONE), : /* F15 : GSXSRESET# ==> NC */ : PAD_NC(GPP_F15, NONE), : /* F16 : GSXCLK ==> NC */ : PAD_NC(GPP_F16, NONE), : /* F17 : WWAN_RF_DISABLE_ODL == NC */ : PAD_NC(GPP_F17, NONE), : /* F18 : THC1_SPI2_INT# ==> NC */ : PAD_NC(GPP_F18, NONE), : /* F19 : SRCCLKREQ6# ==> NC */ : PAD_NC(GPP_F19, NONE), : /* F20 : EXT_PWR_GATE# ==> EXT_PWR_GATE_L */ : PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), : /* F21 : EXT_PWR_GATE2# ==> EXT_PWR_GATE2_L */ : PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), : /* F22 : VNN_CTRL */ : PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1), : /* F23 : V1P05_CTRL */ : PAD_CFG_NF(GPP_F23, NONE, DEEP, NF1), : Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 290: /* H0 : GPPH0_BOOT_STRAP1 */ : PAD_NC(GPP_H0, NONE), : /* H1 : GPPH1_BOOT_STRAP2 */ : PAD_NC(GPP_H1, NONE), : /* H2 : GPPH2_BOOT_STRAP3 */ : PAD_NC(GPP_H2, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 298: /* H4 : I2C2_SDA ==> PCH_I2C2_MISC_SDA */ : PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), : /* H5 : I2C2_SCL ==> PCH_I2C2_MISC_SCL */ : PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), : /* H6 : I2C3_SDA ==> NC */ : PAD_NC(GPP_H6, NONE), : /* H7 : I2C3_SCL ==> NC */ : PAD_NC(GPP_H7, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 312: /* H11 : SRCCLKREQ5# ==> NC */ : PAD_NC(GPP_H11, NONE), : /* H12 : M2_SKT2_CFG0 ==> NC */ : PAD_NC(GPP_H12, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 318: /* H14 : M2_SKT2_CFG2 # ==> NC */ : PAD_NC(GPP_H14, NONE), : /* H15 : M2_SKT2_CFG3 # ==> NC */ : PAD_NC(GPP_H15, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 326: /* H18 : CPU_C10_GATE# ==> CPU_C10_GATE_L */ : PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), : /* H19 : TIME_SYNC0 ==> NC */ : PAD_NC(GPP_H19, NONE), : /* H20 : IMGCLKOUT1 ==> NC */ : PAD_NC(GPP_H20, NONE), : /* H21 : IMGCLKOUT2 ==> NC */ : PAD_NC(GPP_H21, NONE), : /* H22 : IMGCLKOUT3 ==> NC */ : PAD_NC(GPP_H22, NONE), : /* H23 : IMGCLKOUT4 ==> NC */ : PAD_NC(GPP_H23, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 347: /* R4 : HDA_RST# ==> NC */ : PAD_NC(GPP_R4, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 364: /* S4 : SNDW2_CLK ==> NC */ : PAD_NC(GPP_S4, NONE), : /* S5 : SNDW2_DATA ==> NC */ : PAD_NC(GPP_S5, NONE), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 373: /* GPD0: BATLOW# ==> BATLOW_L */ : PAD_CFG_NF(GPD0, NONE, DEEP, NF1), : /* GPD1: ACPRESENT ==> PCH_ACPRESENT */ : PAD_CFG_NF(GPD1, NONE, DEEP, NF1), : /* GPD2: LAN_WAKE# ==> EC_PCH_WAKE_ODL */ : PAD_CFG_NF(GPD2, NONE, DEEP, NF1), : /* GPD3: PWRBTN# ==> EC_PCH_PWR_BTN_ODL */ : PAD_CFG_NF(GPD3, NONE, DEEP, NF1), : /* GPD4: SLP_S3# ==> SLP_S3_L */ : PAD_CFG_NF(GPD4, NONE, DEEP, NF1), : /* GPD5: SLP_S4# ==> SLP_S4_L */ : PAD_CFG_NF(GPD5, NONE, DEEP, NF1), : /* GPD6: SLP_A# ==> SLP_A_L */ : PAD_CFG_NF(GPD6, NONE, DEEP, NF1), : /* GPD7: GPD7_STRAP */ : PAD_CFG_GPI(GPD7, DN_20K, DEEP), : /* GPD8: SUSCLK ==> PCH_SUSCLK */ : PAD_CFG_NF(GPD8, NONE, DEEP, NF1), Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 393: /* GPD10: SLP_S5# ==> SLP_S5_L */ : PAD_CFG_NF(GPD10, NONE, DEEP, NF1), : /* GPD11: LANPHYC ==> NC */ Remove this
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 402: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 408: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 411: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 414: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 417: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 423: Remove this line
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 430: gpio_table rename to override_gpio_table to align with the other project like variant/volteer/gpio.c
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end remove this. You're using max98373 according to the schematic.
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 58: chip drivers/i2c/sx9310 : register "desc" = ""SAR0 Proximity Sensor"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)" : register "speed" = "I2C_SPEED_FAST" : register "uid" = "0" : register "reg_prox_ctrl0" = "0x10" : register "reg_prox_ctrl1" = "0x00" : register "reg_prox_ctrl2" = "0x84" : register "reg_prox_ctrl3" = "0x0e" : register "reg_prox_ctrl4" = "0x07" : register "reg_prox_ctrl5" = "0xc6" : register "reg_prox_ctrl6" = "0x20" : register "reg_prox_ctrl7" = "0x0d" : register "reg_prox_ctrl8" = "0x8d" : register "reg_prox_ctrl9" = "0x43" : register "reg_prox_ctrl10" = "0x1f" : register "reg_prox_ctrl11" = "0x00" : register "reg_prox_ctrl12" = "0x00" : register "reg_prox_ctrl13" = "0x00" : register "reg_prox_ctrl14" = "0x00" : register "reg_prox_ctrl15" = "0x00" : register "reg_prox_ctrl16" = "0x00" : register "reg_prox_ctrl17" = "0x00" : register "reg_prox_ctrl18" = "0x00" : register "reg_prox_ctrl19" = "0x00" : register "reg_sar_ctrl0" = "0x50" : register "reg_sar_ctrl1" = "0x8a" : register "reg_sar_ctrl2" = "0x3c" : device i2c 28 on end : end remove this. I don't see the proximity sensor in the schematic.
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 100: chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" : register "sdmode_delay" = "5" : device generic 0 on : probe AUDIO MAX98357_ALC5682I_I2S : end : end : chip drivers/intel/soundwire : device generic 0 on : probe AUDIO MAX98373_ALC5682_SNDW : chip drivers/soundwire/alc5682 : # SoundWire Link 0 ID 1 : register "desc" = ""Headset Codec"" : device generic 0.1 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 3 : register "desc" = ""Left Speaker Amp"" : device generic 1.3 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 7 : register "desc" = ""Right Speaker Amp"" : device generic 1.7 on end : end : end : end remove this. I don't see the sound wire in the schematic.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#8).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 333 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/8
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 8:
(50 comments)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 22: /* A9 : I2S2_TXD ==> EC_IN_RW_OD */ : PAD_CFG_GPI(GPP_A9, NONE, DEEP),
Remove this because this is same as baseboard/gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 26: /* A11 : PMC_I2C_SDA ==> SSD_PERST_L */ : PAD_CFG_GPO(GPP_A11, 1, DEEP), : /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ : PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 32: /* A14 : USB_OC1# ==> USB_A0_OC_ODL */ : PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), : /* A15 : USB_OC2# ==> USB_A1_OC_ODL */ : PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 38: /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ : PAD_CFG_GPI(GPP_A17, NONE, DEEP),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 46: /* A21 : DDPC_CTRCLK ==> NC */ : PAD_NC(GPP_A21, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 53: /* B0 : CORE_VID0 */ : PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), : /* B1 : CORE_VID1 */ : PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 59: /* B3 : CPU_GP2 ==> NC */ : PAD_NC(GPP_B3, NONE), : /* B4 : CPU_GP3 ==> NC */ : PAD_NC(GPP_B4, NONE), : /* B5 : ISH_I2C0_CVF_SDA == NC */ : PAD_NC(GPP_B5, NONE), : /* B6 : ISH_I2C0_CVF_SCL == NC */ : PAD_NC(GPP_B6, NONE), : /* B7 : ISH_12C1_SDA ==> NC */ : PAD_NC(GPP_B7, NONE), : /* B8 : ISH_I2C1_SCL ==> NC */ : PAD_NC(GPP_B8, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 75: /* B11 : PMCALERT# ==> PCH_WP_OD */ : PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), : /* B12 : SLP_S0# ==> SLP_S0_L */ : PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), : /* B13 : PLTRST# ==> PLT_RST_L */ : PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), : /* B14 : SPKR ==> GPP_B14_STRAP */ : PAD_NC(GPP_B14, NONE), : /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ : PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), : /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ : PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), : /* B17 : GSPI0_MISO ==> PCH_GSPIO_H1_TPM_MISO */ : PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), : /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ : PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), : /* B19 : GSPI1_CS0# ==> NC */ : PAD_NC(GPP_B19, NONE), : /* B20 : GSPI1_CLK ==> NC */ : PAD_NC(GPP_B20, NONE), : /* B21 : GSPI1_MISO ==> NC */ : PAD_NC(GPP_B21, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 99: /* B23 : SML1ALERT# ==> GPP_B23_STRAP # */ : PAD_NC(GPP_B23, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 104: /* C1 : SMBDATA ==> NOT USED */ : PAD_NC(GPP_C1, NONE), : /* C2 : SMBALERT# ==> GPP_C2_STRAP */ : PAD_NC(GPP_C2, NONE), : /* C3 : SML0CLK ==> NC */ : PAD_NC(GPP_C3, NONE), : /* C4 : SML0DATA ==> NC */ : PAD_NC(GPP_C4, NONE), : /* C5 : SML0ALERT# ==> USB_SMB_INT_L_BOOT_STRAP0 */ : PAD_NC(GPP_C5, NONE), : /* C6 : SML1CLK ==> EC_PCH_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_C6, NONE, PLTRST, LEVEL, INVERT), : /* C7 : SML1DATA ==> NC */ : PAD_NC(GPP_C7, NONE), : /* C8 : UART0_RXD ==> UART_PCH_RX_DEBUG_TX */ : PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), : /* C9 : UART0_TXD ==> UART_PCH_TX_DEBUG_RX */ : PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 124: /* C11 : UART0_CTS# ==> NC */ : PAD_NC(GPP_C11, NONE), : /* C12 : UART1_RXD ==> MEM_STRAP_0 */ : PAD_CFG_GPI(GPP_C12, NONE, DEEP), : /* C13 : UART1_TXD ==> NC */ : PAD_NC(GPP_C13, NONE), : /* C14 : UART1_RTS# ==> MEM_STRAP_2 */ : PAD_CFG_GPI(GPP_C14, NONE, DEEP), : /* C15 : UART1_CTS# ==> MEM_STRAP_1 */ : PAD_CFG_GPI(GPP_C15, NONE, DEEP),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 142: /* C20 : UART2_RXD ==> NC */ : PAD_NC(GPP_C20, NONE), : /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), : /* C22 : UART2_RTS# ==> NC */ : PAD_NC(GPP_C22, NONE), : /* C23 : UART2_CTS# ==> NC */ : PAD_NC(GPP_C23, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 151: /* D0 : ISH_GP0 ==> NC */ : PAD_NC(GPP_D0, NONE), : /* D1 : ISH_GP1 ==> NC */ : PAD_NC(GPP_D1, NONE), : /* D2 : ISH_GP2 ==> NC */ : PAD_NC(GPP_D2, NONE), : /* D3 : ISH_GP3 ==> NC */ : PAD_NC(GPP_D3, NONE), : /* D4 : IMGCLKOUT0 ==> NC */ : PAD_NC(GPP_D4, NONE), : /* D5 : SRCCLKREQ0$ ==> SSD_CLKREQ_ODL */ : PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), : /* D6 : SRCCLKREQ1# ==> NC */ : PAD_NC(GPP_D6, NONE), : /* D7 : SRCCLKREQ2# ==> NC */ : PAD_NC(GPP_D7, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 169: /* D9 : ISH_SPI_CS# ==> NC */ : PAD_NC(GPP_D9, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 171: /* D10 : ISH_SPI_CLK ==> PCH_GSPI2_CVF_CLK_STRAP */ : PAD_CFG_NF(GPP_D10, NONE, DEEP, NF7),
Remove this. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 173: /* D11 : ISH_SPI_MISO ==> NC */ : PAD_NC(GPP_D11, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 175: /* D12 : ISH_SPI_MOSI ==> PCH_GSPI2_CVF_MISO_STRAP */ : PAD_CFG_NF(GPP_D12, DN_20K, DEEP, NF7),
Remove this. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 181: /* D15 : ISH_UART0_RTS# ==> MEM_STRAP_3 */ : PAD_CFG_GPI(GPP_D15, NONE, DEEP),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 187: /* D18 : ISH_GP5 ==> NC */ : PAD_NC(GPP_D18, NONE), : /* D19 : I2S_MCLK1 ==> I2S_MCLK1 */ : PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 192: /* E0 : SATAXPCIE0 ==> USB_A1_RT_RST_ODL */ : PAD_CFG_GPO(GPP_E0, 1, DEEP), : /* E1 : SPI1_IO2 ==> NC */ : PAD_NC(GPP_E1, NONE), : /* E2 : SPI1_IO3 ==> NC */ : PAD_NC(GPP_E2, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 202: /* E5 : SATA_DEVSLP1 ==> M2_SSD_DEVSLP_OD */ : PAD_CFG_NF(GPP_E5, NONE, DEEP, NF1), : /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */ : PAD_NC(GPP_E6, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 210: /* E9 : USB2_OC0# ==> USB_C1_OC_ODL */ : PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), : /* E10 : SPI1_CS# ==> USB_C0_AUXP_DC */ : PAD_CFG_NF(GPP_E10, NONE, DEEP, NF6),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 216: /* E12 : SPI1_MISO_IO1 ==> NC */ : PAD_NC(GPP_E12, NONE), : /* E13 : SPI1_MOSI_IO0 ==> USB_C0_AUXN_DC */ : PAD_CFG_NF(GPP_E13, NONE, DEEP, NF6), : /* E14 : DDPC_HPDA ==> SOC_EDP_HPD */ : PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 224: /* E16 : ISH_GP7 ==> NC */ : PAD_NC(GPP_E16, NONE), : /* E17 : THC0_SPI1_INT# ==> NC */ : PAD_NC(GPP_E17, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 230: /* E19 : DDP1_CTRLDATA ==> USB0_C0_LSX_SOC_RX_STRAP */ : PAD_CFG_NF(GPP_E19, NONE, DEEP, NF4),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 234: /* E21 : DDP2_CTRLDATA ==> USB_C1_LSX_SOC_RX_STRAP */ : PAD_CFG_NF(GPP_E21, NONE, DEEP, NF4), : /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E22, NONE), : /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E23, NONE), :
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 241: /* F0 : CNV_BRI_DT ==> CNV_BRI_DT_STRAP */ : PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), : /* F1 : CNV_BRI_RSP ==> NCV_BRI_RSP */ : PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), : /* F2 : I2S2_TXD ==> CNV_RGI_DT_STRAP */ : PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), : /* F3 : I2S2_RXD ==> CNV_RGI_RSP */ : PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), : /* F4 : CNV_RF_RESET# ==> CNV_RF_RST_L */ : PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), : /* F5 : MODEM_CLKREQ ==> CNV_CLKREQ0 */ : PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3), : /* F6 : CNV_PA_BLANKING ==> NC */ : PAD_NC(GPP_F6, NONE), : /* F7 : GPPF7_STRAP */ : PAD_NC(GPP_F7, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 259: /* F9 : Reserved ==> NC */ : PAD_NC(GPP_F9, NONE), : /* F10 : GPPF10_STRAP */ : PAD_NC(GPP_F10, DN_20K),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 265: /* F12 : GSXDOUT ==> NC */ : PAD_NC(GPP_F12, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 269: /* F14 : GSXDIN ==> NC */ : PAD_NC(GPP_F14, NONE), : /* F15 : GSXSRESET# ==> NC */ : PAD_NC(GPP_F15, NONE), : /* F16 : GSXCLK ==> NC */ : PAD_NC(GPP_F16, NONE), : /* F17 : WWAN_RF_DISABLE_ODL == NC */ : PAD_NC(GPP_F17, NONE), : /* F18 : THC1_SPI2_INT# ==> NC */ : PAD_NC(GPP_F18, NONE), : /* F19 : SRCCLKREQ6# ==> NC */ : PAD_NC(GPP_F19, NONE), : /* F20 : EXT_PWR_GATE# ==> EXT_PWR_GATE_L */ : PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), : /* F21 : EXT_PWR_GATE2# ==> EXT_PWR_GATE2_L */ : PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), : /* F22 : VNN_CTRL */ : PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1), : /* F23 : V1P05_CTRL */ : PAD_CFG_NF(GPP_F23, NONE, DEEP, NF1), :
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 290: /* H0 : GPPH0_BOOT_STRAP1 */ : PAD_NC(GPP_H0, NONE), : /* H1 : GPPH1_BOOT_STRAP2 */ : PAD_NC(GPP_H1, NONE), : /* H2 : GPPH2_BOOT_STRAP3 */ : PAD_NC(GPP_H2, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 298: /* H4 : I2C2_SDA ==> PCH_I2C2_MISC_SDA */ : PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), : /* H5 : I2C2_SCL ==> PCH_I2C2_MISC_SCL */ : PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), : /* H6 : I2C3_SDA ==> NC */ : PAD_NC(GPP_H6, NONE), : /* H7 : I2C3_SCL ==> NC */ : PAD_NC(GPP_H7, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 312: /* H11 : SRCCLKREQ5# ==> NC */ : PAD_NC(GPP_H11, NONE), : /* H12 : M2_SKT2_CFG0 ==> NC */ : PAD_NC(GPP_H12, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 318: /* H14 : M2_SKT2_CFG2 # ==> NC */ : PAD_NC(GPP_H14, NONE), : /* H15 : M2_SKT2_CFG3 # ==> NC */ : PAD_NC(GPP_H15, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 326: /* H18 : CPU_C10_GATE# ==> CPU_C10_GATE_L */ : PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), : /* H19 : TIME_SYNC0 ==> NC */ : PAD_NC(GPP_H19, NONE), : /* H20 : IMGCLKOUT1 ==> NC */ : PAD_NC(GPP_H20, NONE), : /* H21 : IMGCLKOUT2 ==> NC */ : PAD_NC(GPP_H21, NONE), : /* H22 : IMGCLKOUT3 ==> NC */ : PAD_NC(GPP_H22, NONE), : /* H23 : IMGCLKOUT4 ==> NC */ : PAD_NC(GPP_H23, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 347: /* R4 : HDA_RST# ==> NC */ : PAD_NC(GPP_R4, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 364: /* S4 : SNDW2_CLK ==> NC */ : PAD_NC(GPP_S4, NONE), : /* S5 : SNDW2_DATA ==> NC */ : PAD_NC(GPP_S5, NONE),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 373: /* GPD0: BATLOW# ==> BATLOW_L */ : PAD_CFG_NF(GPD0, NONE, DEEP, NF1), : /* GPD1: ACPRESENT ==> PCH_ACPRESENT */ : PAD_CFG_NF(GPD1, NONE, DEEP, NF1), : /* GPD2: LAN_WAKE# ==> EC_PCH_WAKE_ODL */ : PAD_CFG_NF(GPD2, NONE, DEEP, NF1), : /* GPD3: PWRBTN# ==> EC_PCH_PWR_BTN_ODL */ : PAD_CFG_NF(GPD3, NONE, DEEP, NF1), : /* GPD4: SLP_S3# ==> SLP_S3_L */ : PAD_CFG_NF(GPD4, NONE, DEEP, NF1), : /* GPD5: SLP_S4# ==> SLP_S4_L */ : PAD_CFG_NF(GPD5, NONE, DEEP, NF1), : /* GPD6: SLP_A# ==> SLP_A_L */ : PAD_CFG_NF(GPD6, NONE, DEEP, NF1), : /* GPD7: GPD7_STRAP */ : PAD_CFG_GPI(GPD7, DN_20K, DEEP), : /* GPD8: SUSCLK ==> PCH_SUSCLK */ : PAD_CFG_NF(GPD8, NONE, DEEP, NF1),
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 393: /* GPD10: SLP_S5# ==> SLP_S5_L */ : PAD_CFG_NF(GPD10, NONE, DEEP, NF1), : /* GPD11: LANPHYC ==> NC */
Remove this
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 402:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 408:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 411:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 414:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 417:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 423:
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 430: gpio_table
rename to override_gpio_table to align with the other project like variant/volteer/gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
remove this. You're using max98373 according to the schematic.
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 58: chip drivers/i2c/sx9310 : register "desc" = ""SAR0 Proximity Sensor"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)" : register "speed" = "I2C_SPEED_FAST" : register "uid" = "0" : register "reg_prox_ctrl0" = "0x10" : register "reg_prox_ctrl1" = "0x00" : register "reg_prox_ctrl2" = "0x84" : register "reg_prox_ctrl3" = "0x0e" : register "reg_prox_ctrl4" = "0x07" : register "reg_prox_ctrl5" = "0xc6" : register "reg_prox_ctrl6" = "0x20" : register "reg_prox_ctrl7" = "0x0d" : register "reg_prox_ctrl8" = "0x8d" : register "reg_prox_ctrl9" = "0x43" : register "reg_prox_ctrl10" = "0x1f" : register "reg_prox_ctrl11" = "0x00" : register "reg_prox_ctrl12" = "0x00" : register "reg_prox_ctrl13" = "0x00" : register "reg_prox_ctrl14" = "0x00" : register "reg_prox_ctrl15" = "0x00" : register "reg_prox_ctrl16" = "0x00" : register "reg_prox_ctrl17" = "0x00" : register "reg_prox_ctrl18" = "0x00" : register "reg_prox_ctrl19" = "0x00" : register "reg_sar_ctrl0" = "0x50" : register "reg_sar_ctrl1" = "0x8a" : register "reg_sar_ctrl2" = "0x3c" : device i2c 28 on end : end
remove this. I don't see the proximity sensor in the schematic.
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 100: chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" : register "sdmode_delay" = "5" : device generic 0 on : probe AUDIO MAX98357_ALC5682I_I2S : end : end : chip drivers/intel/soundwire : device generic 0 on : probe AUDIO MAX98373_ALC5682_SNDW : chip drivers/soundwire/alc5682 : # SoundWire Link 0 ID 1 : register "desc" = ""Headset Codec"" : device generic 0.1 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 3 : register "desc" = ""Left Speaker Amp"" : device generic 1.3 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 7 : register "desc" = ""Right Speaker Amp"" : device generic 1.7 on end : end : end : end
remove this. I don't see the sound wire in the schematic.
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 140: con
same as above.
Done
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 134: con
typo 'con' should be 'conn'
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#9).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 333 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/9
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#10).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 333 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/10
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 9: gpio_table override_gpio_table
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 170: gpio_table You need to change this to override_gpio_table. Please build it locally before submitting.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Ravishankar Sarawadi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#11).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 333 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/11
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 42: device pci 15.2 on : end # I2C2 0xA0EA Turn off it?
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end Turn off it?
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC Delbin only support typec usb3. Do we need this?
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG@13 PS11, Line 13: BRANCH=volteer no branch yet.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end
Turn off it?
1f.3 is HD audio, i don't think you want to turn it off. however, i think you can remove these 2 lines as they match devicetree.cb.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 64: SBU sbu is fixed since you have a ps8815 in the path. this should be the same as C1.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC
Delbin only support typec usb3. […]
yes, for type-C ports connected to the TCP0..3 ports on the SoC, this is needed.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/memory.c:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 5: malefor_memcfg delbin_memcfg ?
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 59: malefor_memcfg delbin_memcfg ?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#12).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 348 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/12
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#13).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 347 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/13
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
Done
Dear Zhuohao, We remove this code audio will not work. so we add back this code, and remove "MAX98357_ALC5682I_I2S".
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
Dear Zhuohao, […]
My bad. sorry about that.
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 55: device pci 15.2 on : end # I2C2 0xA0EA We can use the baseboard setting. Remove this?
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 67: device pci 1f.3 on : end We can use the baseboard setting. Remove this?
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 15: probe AUDIO MAX98373_ALC5682I_I2S Could you please check if we need this? I think it is not necessary.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#14).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 342 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/14
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 15: probe AUDIO MAX98373_ALC5682I_I2S
Could you please check if we need this? I think it is not necessary.
Done
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 55: device pci 15.2 on : end # I2C2 0xA0EA
We can use the baseboard setting. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 67: device pci 1f.3 on : end
We can use the baseboard setting. […]
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 14: Code-Review+1
Furquan/Nick/Caveh, could you please help to review this patch again?
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 14:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 9: gpio_table
override_gpio_table
Done
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 170: gpio_table
You need to change this to override_gpio_table. Please build it locally before submitting.
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/memory.c:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 5: malefor_memcfg
delbin_memcfg ?
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 59: malefor_memcfg
delbin_memcfg ?
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end
1f.3 is HD audio, i don't think you want to turn it off. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 15: end we usually put the "end" on the same line as the "device" when there's nothing in the block.
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 24: probe AUDIO MAX98373_ALC5682I_I2S the probe statements for the AMPs can go away as well.
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2 this is I2C2, did you mean 19.1?
if you don't have anything on i2c2, you can turn it off here as it's enabled in devicetree.cb. looks like you have pch_i2c2_misc routed somewhere, so probably keep it on.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#15).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 337 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/15
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 15: end
we usually put the "end" on the same line as the "device" when […]
Done
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 24: probe AUDIO MAX98373_ALC5682I_I2S
the probe statements for the AMPs can go away as well.
Done
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... PS15, Line 8: /* Leave eSPI pins untouched from default settings */ Can delete this.
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... PS15, Line 10: /* A0 thru A6 come configured out of reset, do not touch */ : /* A0 : ESPI_IO0 ==> ESPI_IO_0 */ : /* A1 : ESPI_IO1 ==> ESPI_IO_1 */ : /* A2 : ESPI_IO2 ==> ESPI_IO_2 */ : /* A3 : ESPI_IO3 ==> ESPI_IO_3 */ : /* A4 : ESPI_CS# ==> ESPI_CS_L */ : /* A5 : ESPI_CLK ==> ESPI_CLK */ : /* A6 : ESPI_RESET# ==> NC(TP764) */ : Please delete these.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#16).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 327 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/16
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... PS15, Line 8: /* Leave eSPI pins untouched from default settings */
Can delete this.
Done
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte... PS15, Line 10: /* A0 thru A6 come configured out of reset, do not touch */ : /* A0 : ESPI_IO0 ==> ESPI_IO_0 */ : /* A1 : ESPI_IO1 ==> ESPI_IO_1 */ : /* A2 : ESPI_IO2 ==> ESPI_IO_2 */ : /* A3 : ESPI_IO3 ==> ESPI_IO_3 */ : /* A4 : ESPI_CS# ==> ESPI_CS_L */ : /* A5 : ESPI_CLK ==> ESPI_CLK */ : /* A6 : ESPI_RESET# ==> NC(TP764) */ :
Please delete these.
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 16: Code-Review+1
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/16//COMMIT_MSG@13 PS16, Line 13: volteer We haven't created the volteer firmware branch. Please set to None.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#17).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 327 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/17
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/16//COMMIT_MSG@13 PS16, Line 13: volteer
We haven't created the volteer firmware branch. Please set to None.
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17: Code-Review+2
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2
this is I2C2, did you mean 19.1? […]
PCH_i2C2_misc connect to HDMI .
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2
PCH_i2C2_misc connect to HDMI .
"pci 15.2" is i2c2 and that does not match the comment on line 63. according to your schematics, the touchpad is under i2c5, so this should be changed to "pci 19.1".
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17: -Code-Review
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2
"pci 15.2" is i2c2 and that does not match the comment on line 63. […]
Ken, you remove it wrongly starting from Patchset14. It is 19.1.
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#18).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 327 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/18
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2
Ken, you remove it wrongly starting from Patchset14. It is 19.1.
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 18: Code-Review+1
It looks like the error is not related to this patch:
From https://review.coreboot.org/coreboot * branch refs/changes/01/42301/18 -> FETCH_HEAD fatal: not a git repository: 3rdparty/amd_blobs/../../.git/modules/3rdparty/amd_blobs
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2436) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:2050) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:84) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:572) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154) at hudson.remoting.UserRequest.perform(UserRequest.java:211) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.lang.Thread.run(Thread.java:834) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to gleefulbuilder at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356) at hudson.remoting.Channel.call(Channel.java:998) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor198.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy76.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:913) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1141) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1177) at hudson.scm.SCM.checkout(SCM.java:505) at hudson.model.AbstractProject.checkout(AbstractProject.java:1206) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1880) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:428) ERROR: Error fetching remote repo 'origin' Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] done Finished: FAILURE
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 18:
(1 comment)
I will +2 once the comment in gpio.c is added. Thanks.
https://review.coreboot.org/c/coreboot/+/42301/18/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/18/src/mainboard/google/volte... PS18, Line 9: PAD_CFG_GPO(GPP_A7, 1, DEEP), I'm sorry, I realize my last comment asked that these lines be deleted, but I didn't mean to include the A7 comment as part of those that should be deleted. Please add the comment for this GPIO. Thanks.
Ken Lu has uploaded a new patch set (#19) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 328 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/19
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/19/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/19/src/mainboard/google/volte... PS19, Line 9: /* A7 : I2S2_SCLK ==> EN_PP3300_TRACKPAD */ trailing whitespace
Ken Lu has uploaded a new patch set (#20) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 328 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/20
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/18/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/18/src/mainboard/google/volte... PS18, Line 9: PAD_CFG_GPO(GPP_A7, 1, DEEP),
I'm sorry, I realize my last comment asked that these lines be deleted, but I didn't mean to include […]
Done
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20: Code-Review-1
please fix port C0 config.
Nick Vaccaro has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Removed Code-Review+2 by Nick Vaccaro nvaccaro@google.com
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 106: I2S0_PCH_TX_HP_RX_STRAP * please change to: I2S0_PCH_TX_HP_RX
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0, Even we don't use this SNDW interface, we are configuring them, right?
Trying to understand.. if they should be as in : fw_config.c/sndw_disable_pads ?
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG@13 PS11, Line 13: BRANCH=volteer
no branch yet.
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 42: device pci 15.2 on : end # I2C2 0xA0EA
Turn off it?
Done
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC
yes, for type-C ports connected to the TCP0..3 ports on the SoC, this is needed.
Delbin port C1 follow design of volteer. So we use the same setting on port C1 as volteer.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(1 comment)
Patch Set 20: Code-Review-1
please fix port C0 config.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 64: SBU
sbu is fixed since you have a ps8815 in the path. this should be the same as C1.
Done
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#21).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 328 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/21
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 106: I2S0_PCH_TX_HP_RX_STRAP *
please change to: […]
Done
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#22).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 320 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/22
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0,
Even we don't use this SNDW interface, we are configuring them, right? […]
Dear Sathyanarayana We remove GPP_S0, GPP_S1, GPP_S2, GPP_S3 and measuring, signal has not changed. so we remove this setting, thanks.
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0,
Dear Sathyanarayana […]
Thank you Ken. After removing GPP_S0~S3, audio pb/cap works, right?
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0,
Thank you Ken. […]
Dear Sathyanarayana, Yes, removed GPP_S0~GPP_S3, audio can work, thanks.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22: Code-Review+2
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22: Code-Review+1
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 22: Code-Review+1
Hello Sathyanarayana Nujella, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Martin Roth, Caveh Jalali, Ravishankar Sarawadi, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42301
to look at the new patch set (#23).
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 321 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42301/23
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23: Code-Review+1
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/19/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/19/src/mainboard/google/volte... PS19, Line 9: /* A7 : I2S2_SCLK ==> EN_PP3300_TRACKPAD */
trailing whitespace
Done
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23:
(4 comments)
Patch Set 20: Code-Review-1
please fix port C0 config.
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG@9 PS1, Line 9: Create the Mudada variant of the volteer.
We copy it from volteer folder and modify settings follow mudada design .
Done
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0,
Dear Sathyanarayana, […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
My bad. sorry about that.
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC
Delbin port C1 follow design of volteer. So we use the same setting on port C1 as volteer.
Done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23: Code-Review+2
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
mb/google/volteer: Modify Delbin variant
Update delbin configuration include GPIO, memory SPD table, I2C devices and USB type C.
BUG=b:158797761 BRANCH=None TEST=emerge-volteer coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea Reviewed-on: https://review.coreboot.org/c/coreboot/+/42301 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/volteer/variants/delbin/Makefile.inc A src/mainboard/google/volteer/variants/delbin/gpio.c A src/mainboard/google/volteer/variants/delbin/memory.c A src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc A src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt M src/mainboard/google/volteer/variants/delbin/overridetree.cb 7 files changed, 321 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sathyanarayana Nujella: Looks good to me, but someone else must approve Caveh Jalali: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/delbin/Makefile.inc b/src/mainboard/google/volteer/variants/delbin/Makefile.inc new file mode 100644 index 0000000..343c7db --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/Makefile.inc @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only + +romstage-y += memory.c + +bootblock-y += gpio.c + +ramstage-y += gpio.c diff --git a/src/mainboard/google/volteer/variants/delbin/gpio.c b/src/mainboard/google/volteer/variants/delbin/gpio.c new file mode 100644 index 0000000..614ff6c --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/gpio.c @@ -0,0 +1,160 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <commonlib/helpers.h> + +/* Pad configuration in ramstage */ +static const struct pad_config override_gpio_table[] = { + /* A7 : I2S2_SCLK ==> EN_PP3300_TRACKPAD */ + PAD_CFG_GPO(GPP_A7, 1, DEEP), + /* A8 : I2S2_SFRM ==> EN_PP3300_TOUCHSCREEN */ + PAD_CFG_GPO(GPP_A8, 0, DEEP), + /* A10 : I2S2_RXD ==> EN_SPKR_PA */ + PAD_CFG_GPO(GPP_A10, 1, DEEP), + /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), + /* A16 : USB_OC3# ==> USB_C0_OC_ODL */ + PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), + /* A18 : DDSP_HPDB ==> HDMI_HPD */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), + /* A19 : DDSP_HPD1 ==> USB_C0_DP_HPD */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), + /* A20 : DDSP_HPD2 ==> USB_C1_DP_HPD */ + PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), + /* A22 : DDPC_CTRLDATA ==> EN_HDMI_PWR */ + PAD_CFG_GPO(GPP_A22, 1, DEEP), + /* A23 : I2S1_SCLK ==> I2S1_SPKR_SCLK */ + PAD_CFG_NF(GPP_A23, NONE, DEEP, NF1), + + /* B2 : VRALERT# ==> NC */ + PAD_NC(GPP_B2, NONE), + /* B9 : I2C5_SDA ==> PCH_I2C5_TRACKPAD_SDA */ + PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), + /* B10 : I2C5_SCL ==> PCH_I2C5_TRACKPAD_SCL */ + PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), + /* B22 : GSPI1_MOSI ==> NC */ + PAD_NC(GPP_B22, NONE), + + /* C0 : SMBCLK ==> EN_PP3300_WLAN */ + PAD_CFG_GPO(GPP_C0, 1, DEEP), + /* C10 : UART0_RTS# ==> USI_RST_L */ + PAD_CFG_GPO(GPP_C10, 0, DEEP), + /* C16 : I2C0_SDA ==> PCH_I2C0_1V8_AUDIO_SDA */ + PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), + /* C17 : I2C0_SCL ==> PCH_I2C0_1V8_AUDIO_SCL */ + PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), + /* C18 : I2C1_SDA ==> PCH_I2C1_TOUCH_USI_SDA */ + PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), + /* C19 : I2C1_SCL ==> PCH_I2C1_TOUCH_USI_SCL */ + PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), + + /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ + PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), + /* D13 : ISH_UART0_RXD ==> UART_ISH_RX_DEBUG_TX */ + PAD_CFG_NF(GPP_D13, NONE, DEEP, NF1), + /* D14 : ISH_UART0_TXD ==> UART_ISH_TX_DEBUG_RX */ + PAD_CFG_NF(GPP_D14, NONE, DEEP, NF1), + /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* D17 : ISH_GP4 ==> EN_FCAM_PWR */ + PAD_CFG_GPO(GPP_D17, 1, DEEP), + + /* E3 : CPU_GP0 ==> USI_REPORT_EN */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), + /* E4 : SATA_DEVSLP0 ==> M2_SSD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E4, NONE, DEEP), + /* E7 : CPU_GP1 ==> USI_INT */ + PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE), + /* E8 : SPI1_CS1# ==> SLP_S0IX */ + PAD_CFG_GPO(GPP_E8, 0, DEEP), + /* E11 : SPI1_CLK ==> SD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E11, NONE, DEEP), + /* E15 : ISH_GP6 ==> TRACKPAD_INT_ODL */ + PAD_CFG_GPI_IRQ_WAKE(GPP_E15, NONE, DEEP, LEVEL, INVERT), + /* E18 : DDP1_CTRLCLK ==> NC */ + PAD_NC(GPP_E18, NONE), + /* E20 : DDP2_CTRLCLK ==> NC */ + PAD_NC(GPP_E20, NONE), + + /* F8 : I2S_MCLK2_INOUT ==> HP_INT_L */ + PAD_CFG_GPI_INT(GPP_F8, NONE, PLTRST, EDGE_BOTH), + /* F11 : GPPF11_THC1_SPI2_CLK ==> NC */ + PAD_NC(GPP_F12, NONE), + /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ + PAD_CFG_GPO(GPP_F13, 1, DEEP), + + /* H3 : SX_EXIT_HOLDOFF# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H3, 1, DEEP), + /* H8 : I2C4_SDA ==> PCB_ID0 */ + PAD_CFG_GPI(GPP_H8, NONE, DEEP), + /* H9 : I2C4_SCL ==> PCB_ID1 */ + PAD_CFG_GPI(GPP_H9, NONE, DEEP), + /* H10 : SRCCLKREQ4# ==> NC */ + PAD_NC(GPP_H10, NONE), + /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */ + PAD_CFG_GPI(GPP_H13, NONE, DEEP), + /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */ + PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), + /* H17 : DDPB_CTRLDATA ==> DDPB_HDMI_CTRLDATA */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), + + /* R0 : HDA_BCLK ==> I2S0_HP_SCLK */ + PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2), + /* R1 : HDA_SYNC ==> I2S0_HP_SFRM */ + PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), + /* R2 : HDA_SDO ==> I2S0_PCH_TX_HP_RX */ + PAD_CFG_NF(GPP_R2, DN_20K, DEEP, NF2), + /* R3 : HDA_SDIO ==> I2S0_PCH_RX_HP_TX */ + PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), + /* R5 : HDA_SDI1 ==> I2S1_PCH_RX_SPKR_TX */ + PAD_CFG_NF(GPP_R5, NONE, DEEP, NF2), + /* R6 : I2S1_TXD ==> I2S1_PCH_RX_SPKR_RX */ + PAD_CFG_NF(GPP_R6, NONE, DEEP, NF2), + /* R7 : I2S1_SFRM ==> I2S1_SPKR_SFRM */ + PAD_CFG_NF(GPP_R7, NONE, DEEP, NF2), + + /* S6 : SNDW3_CLK ==> DMIC_CLK0 */ + PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), + /* S7 : SNDW3_DATA ==> DMIC_DATA0 */ + PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), + + /* GPD9: SLP_WLAN# ==> SLP_WLAN_L */ + PAD_CFG_NF(GPD9, NONE, DEEP, NF1), +}; + +/* Early pad configuration in bootblock */ +static const struct pad_config early_gpio_table[] = { + /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ + PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), + /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ + PAD_CFG_GPI(GPP_A17, NONE, DEEP), + + /* B11 : PMCALERT# ==> PCH_WP_OD */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), + /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ + PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), + /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ + PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), + /* B17 : GSPI0_MISO ==> PCH_GSPIO_H1_TPM_MISO */ + PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), + /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ + PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), + + /* C0 : SMBCLK ==> EN_PP3300_WLAN */ + PAD_CFG_GPO(GPP_C0, 1, DEEP), + /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), +}; + +const struct pad_config *variant_override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(override_gpio_table); + return override_gpio_table; +} + +const struct pad_config *variant_early_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(early_gpio_table); + return early_gpio_table; +} diff --git a/src/mainboard/google/volteer/variants/delbin/memory.c b/src/mainboard/google/volteer/variants/delbin/memory.c new file mode 100644 index 0000000..788ba51 --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/memory.c @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/variants.h> + +static const struct lpddr4x_cfg delbin_memcfg = { + /* DQ byte map */ + .dq_map = { + [0] = { + { 3, 2, 1, 0, 4, 5, 7, 6, }, /* DDR0_DQ0[7:0] */ + { 12, 13, 14, 15, 11, 10, 9, 8 }, /* DDR0_DQ1[7:0] */ + }, + [1] = { + { 0, 7, 1, 6, 2, 5, 3, 4, }, /* DDR1_DQ0[7:0] */ + { 8, 15, 14, 9, 12, 10, 13, 11 }, /* DDR1_DQ1[7:0] */ + }, + [2] = { + { 2, 3, 0, 1, 4, 5, 6, 7, }, /* DDR2_DQ0[7:0] */ + { 12, 13, 15, 14, 11, 10, 9, 8 }, /* DDR2_DQ1[7:0] */ + }, + [3] = { + { 7, 0, 1, 6, 5, 4, 2, 3, }, /* DDR3_DQ0[7:0] */ + { 15, 14, 8, 9, 10, 13, 11, 12 }, /* DDR3_DQ1[7:0] */ + }, + [4] = { + { 4, 5, 2, 3, 7, 6, 0, 1, }, /* DDR4_DQ0[7:0] */ + { 12, 13, 15, 14, 11, 10, 8, 9 }, /* DDR4_DQ1[7:0] */ + }, + [5] = { + { 3, 4, 2, 5, 0, 6, 1, 7, }, /* DDR5_DQ0[7:0] */ + { 12, 13, 11, 10, 14, 15, 9, 8 }, /* DDR5_DQ1[7:0] */ + }, + [6] = { + { 3, 2, 1, 0, 7, 4, 5, 6, }, /* DDR6_DQ0[7:0] */ + { 15, 14, 13, 12, 8, 9, 10, 11 }, /* DDR6_DQ1[7:0] */ + }, + [7] = { + { 2, 4, 3, 5, 1, 0, 7, 6, }, /* DDR7_DQ0[7:0] */ + { 14, 15, 9, 8, 12, 10, 11, 13 }, /* DDR7_DQ1[7:0] */ + }, + }, + + /* DQS CPU<>DRAM map */ + .dqs_map = { + [0] = { 0, 1 }, /* DDR0_DQS[1:0] */ + [1] = { 0, 1 }, /* DDR1_DQS[1:0] */ + [2] = { 0, 1 }, /* DDR2_DQS[1:0] */ + [3] = { 0, 1 }, /* DDR3_DQS[1:0] */ + [4] = { 0, 1 }, /* DDR4_DQS[1:0] */ + [5] = { 0, 1 }, /* DDR5_DQS[1:0] */ + [6] = { 0, 1 }, /* DDR6_DQS[1:0] */ + [7] = { 0, 1 }, /* DDR7_DQS[1:0] */ + }, + + .ect = 1, /* Enable Early Command Training */ +}; + +const struct lpddr4x_cfg *variant_memory_params(void) +{ + return &delbin_memcfg; +} diff --git a/src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc b/src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc new file mode 100644 index 0000000..7aa547b --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += spd-2.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt new file mode 100644 index 0000000..b5bd3ef --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/memory/dram_id.generated.txt @@ -0,0 +1,5 @@ +DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +H9HCNNNBKMMLXR-NEE 0 (0000) +H9HCNNNCPMMLXR-NEE 2 (0010) diff --git a/src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt new file mode 100644 index 0000000..b99b811 --- /dev/null +++ b/src/mainboard/google/volteer/variants/delbin/memory/mem_list_variant.txt @@ -0,0 +1,4 @@ +MT53E512M32D2NP-046 WT:E +MT53E1G32D2NP-046 WT:A +H9HCNNNBKMMLXR-NEE +H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb index 9b5ae62..fc549c7 100644 --- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb +++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb @@ -1,5 +1,82 @@ chip soc/intel/tigerlake device domain 0 on + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "0" + register "imon_slot_no" = "1" + register "uid" = "0" + register "desc" = ""Right Speaker Amp"" + register "name" = ""MAXR"" + device i2c 31 on end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "2" + register "imon_slot_no" = "3" + register "uid" = "1" + register "desc" = ""Left Speaker Amp"" + register "name" = ""MAXL"" + device i2c 32 on end + end + end + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""ELAN9008"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + end # I2C1 0xA0E9 + device pci 19.1 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" + register "wake" = "GPE0_DW2_15" + register "probed" = "1" + device i2c 15 on end + end + end # I2C5 0xA0C6 + device pci 1f.2 hidden + # The pmc_mux chip driver is a placeholder for the + # PMC.MUX device in the ACPI hierarchy. + chip drivers/intel/pmc_mux + device generic 0 on + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "9" + register "usb3_port_number" = "1" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 0 on end + end + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "4" + register "usb3_port_number" = "2" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 1 on end + end + end + end + end # PMC end - end