8 comments:
File src/mainboard/google/volteer/variants/delbin/gpio.c:
Patch Set #10, Line 9: gpio_table
override_gpio_table
Done
Patch Set #10, Line 170: gpio_table
You need to change this to override_gpio_table. Please build it locally before submitting.
Done
File src/mainboard/google/volteer/variants/delbin/memory.c:
Patch Set #11, Line 5: malefor_memcfg
delbin_memcfg ?
Done
Patch Set #11, Line 59: malefor_memcfg
delbin_memcfg ?
Done
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
device pci 1f.3 on
end
1f.3 is HD audio, i don't think you want to turn it off. […]
Done
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
we usually put the "end" on the same line as the "device" when
there's nothing in the block.
Patch Set #14, Line 24: probe AUDIO MAX98373_ALC5682I_I2S
the probe statements for the AMPs can go away as well.
this is I2C2, did you mean 19.1?
if you don't have anything on i2c2, you can turn it off here
as it's enabled in devicetree.cb. looks like you have
pch_i2c2_misc routed somewhere, so probably keep it on.
To view, visit change 42301. To unsubscribe, or for help writing mail filters, visit settings.