Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 )
Change subject: soc/amd/common: Add some ESPI register definitions
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/51747/comment/d452ba8d_7b2277db
PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1 0x48
Ack.
i'd say that those are unnecessary and probably not too useful, but it also doesn't really hurt to have those in here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af
Gerrit-Change-Number: 51747
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:22:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment