Change in coreboot[master]: cpu/x86/mtrr.h: Rename MSR SMRR_PHYS_x to IA32_SMRR_PHYSx - coreboot-gerrit

24 Jul 2018


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27584 )
Change subject: cpu/x86/mtrr.h: Rename MSR SMRR_PHYS_x to IA32_SMRR_PHYSx
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
not so sure about dropping the _ before BASE and MASK (as it exists nearly everywhere else), but no strong opinion about it either
https://review.coreboot.org/#/c/27584/1/src/include/cpu/x86/mtrr.h
File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/#/c/27584/1/src/include/cpu/x86/mtrr.h@31
PS1, Line 31: 	
by my count, there's an extra tab now, no?
-- 
To view, visit https://review.coreboot.org/27584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54875f3a6d98a28004d5bd3197923862af8f7377
Gerrit-Change-Number: 27584
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 24 Jul 2018 11:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes