Attention is currently required from: Subrata Banik, Kapil Porwal, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73896 )
Change subject: mb/google/brya/variants/hades: Update GPU power sequencing to add Hades support ......................................................................
Patch Set 22:
(1 comment)
File src/mainboard/google/brya/variants/hades/variant.c:
https://review.coreboot.org/c/coreboot/+/73896/comment/4100aa9d_95051fd2 PS22, Line 148: void variant_fill_ssdt(const struct device *dev)
Since we have power.asl, why just put the _INI into it? It'd better all C code or all ASL code.
This is for logic meant to allow Agah devices to dynamically change these values at runtime based on board ID. It isn't really needed for Hades so why these seems a bit pointless here.
Once we drop Agah, we can get rid of this completely. I'm trying to keep power.asl as compatible/common with both devices (for now) and this was the most straightforward.