Attention is currently required from: Frank Wu, Kangheui Won, Isaac Lee, Tim Wawrzynczak, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68154 )
Change subject: spd/lp5: Add new memory configuration of H9JCNNNFA5MLYR-N6E
......................................................................
Patch Set 2:
(1 comment)
File spd/lp5/set-0/parts_spd_manifest.generated.txt:
https://review.coreboot.org/c/coreboot/+/68154/comment/713de4aa_52e8d64d
PS2, Line 19: H9JCNNNFA5MLYR-N6E,spd-9.hex
Where is the spd-9.hex file checked in? I dont see it as part of this commit and also not seeing it already in the tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9926a5859cf060e0bfa903f47d8a98c8d6115579
Gerrit-Change-Number: 68154
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 18:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment