Change in coreboot[master]: libpayload: Improve rtc functions - coreboot-gerrit

4 Mar 2020


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18498 )
Change subject: libpayload: Improve rtc functions
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/18498/1/payloads/libpayload/drivers... 
File payloads/libpayload/drivers/nvram.c:
https://review.coreboot.org/c/coreboot/+/18498/1/payloads/libpayload/drivers... 
PS1, Line 169: struct tm *time
...
Please use a `const struct tm *`, it's not likely that callers would […]
This change was extracted into its own commit, but now done there.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/18498
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id773c33e228973e190a7e14c3d11979678b1a619
Gerrit-Change-Number: 18498
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Wed, 04 Mar 2020 11:01:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment