Attention is currently required from: Julius Werner, Maximilian Brune.
Jakub "Kuba" Czapiga has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86770?usp=email )
Change subject: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 ......................................................................
Patch Set 4:
(4 comments)
File src/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/86770/comment/e496620c_79f88727?usp... : PS4, Line 15: Unnecessary empty line (I think)
File tests/include/tests/lib/fmap_config.h:
PS4: Broader test FMAP is already defined in `tests/include/tests/lib/fmap/fmap_config.h`.
File tests/lib/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86770/comment/d8e28565_c26c9eca?usp... : PS4, Line 150: coreboot_table-test-cflags += -I tests/include/tests/lib/fmap Use this include path instead of `tests/include/tests/lib`
https://review.coreboot.org/c/coreboot/+/86770/comment/55df7489_e860a695?usp... : PS4, Line 166: spd_cache-ddr3-test-cflags += -D__TEST_SPD_CACHE_DDR=3 Duplicate line