Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
Patch Set 23:
(2 comments)
Tested on a supermicro board, works fine.
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/Makefile.inc
File src/superio/aspeed/Makefile.inc:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/Makefile.inc@18
PS17, Line 18: romstage-$(CONFIG_SUPERIO_ASPEED_COMMON_ROMSTAGE) += common/early_serial.c
Done
not done in latest revision.
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/Kconfig
File src/superio/aspeed/common/Kconfig:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/Kconfig@2...
PS17, Line 20: ROMSTAGE
Done
not done in latest revision.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 23
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 16 May 2019 09:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment
Patrick Rudolph (Code Review)