Change in coreboot[master]: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info()
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39961 )
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info()
No longer needed anywhere
Change-Id: Ifeea76af44377d917ec46cac0d9d7375d1a68204 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/emulation/qemu-q35/mainboard.c 1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39961/1
diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c index aea6d41..4ccbcd0 100644 --- a/src/mainboard/emulation/qemu-q35/mainboard.c +++ b/src/mainboard/emulation/qemu-q35/mainboard.c @@ -16,7 +16,6 @@ #include <device/pci.h> #include <device/pci_ops.h> #include <pc80/keyboard.h> -#include <drivers/intel/gma/i915.h>
#define Q35_PAM0 0x90
@@ -25,14 +24,6 @@ 10, 10, 11, 11, };
-struct i915_gpu_controller_info gfx_controller_info = GMA_STATIC_DISPLAYS(0); - -const struct i915_gpu_controller_info * -intel_gma_get_controller_info(void) -{ - return &gfx_controller_info; -} - static void qemu_nb_init(struct device *dev) { /* Map memory at 0xc0000 - 0xfffff */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39961 )
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39961/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39961/2//COMMIT_MSG@9 PS2, Line 9: No longer needed anywhere Period at the end of the sentence
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39961
to look at the new patch set (#3).
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info()
No longer needed anywhere.
Change-Id: Ifeea76af44377d917ec46cac0d9d7375d1a68204 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/emulation/qemu-q35/mainboard.c 1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39961/3
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39961 )
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39961/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39961/2//COMMIT_MSG@9 PS2, Line 9: No longer needed anywhere
Period at the end of the sentence
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39961 )
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
Patch Set 3: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39961 )
Change subject: mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info() ......................................................................
mb/emulation/qemu-q35: drop unused intel_gma_get_controller_info()
No longer needed anywhere.
Change-Id: Ifeea76af44377d917ec46cac0d9d7375d1a68204 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39961 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/emulation/qemu-q35/mainboard.c 1 file changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c index aea6d41..4ccbcd0 100644 --- a/src/mainboard/emulation/qemu-q35/mainboard.c +++ b/src/mainboard/emulation/qemu-q35/mainboard.c @@ -16,7 +16,6 @@ #include <device/pci.h> #include <device/pci_ops.h> #include <pc80/keyboard.h> -#include <drivers/intel/gma/i915.h>
#define Q35_PAM0 0x90
@@ -25,14 +24,6 @@ 10, 10, 11, 11, };
-struct i915_gpu_controller_info gfx_controller_info = GMA_STATIC_DISPLAYS(0); - -const struct i915_gpu_controller_info * -intel_gma_get_controller_info(void) -{ - return &gfx_controller_info; -} - static void qemu_nb_init(struct device *dev) { /* Map memory at 0xc0000 - 0xfffff */
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)