Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Sridhar Siricilla, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55631 )
Change subject: soc/intel/common/cse: Add support for sending CSE End-of-Post message
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/55631/comment/8ada29d7_930ebbbd
PS10, Line 74: SOC_INTEL_CSE_SET_EOP
There is a UPD that controls when/if FSP should send the EOP message. […]
Correct, I also believe (would have to confirm) the CSE will return an error if you try to send EOP again. With this patch series, we also gain the flexibility to perform CSE Pre-boot commands any time before coreboot sends EOP instead of it being dictated by FSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f667905f759cc2337daca4cc6e09694e68ab7e8
Gerrit-Change-Number: 55631
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 22 Jun 2021 16:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment