Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42480 )
Change subject: mb/*/*/Kconfig: guard board name in quotes ......................................................................
mb/*/*/Kconfig: guard board name in quotes
New kconfig dislikes unquoted slashes.
Change-Id: Ief242de081071021b9c904a24535d025f6674270 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/asrock/b85m_pro4/Kconfig M src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig M src/mainboard/asus/p8z77-v_lx2/Kconfig M src/mainboard/dell/optiplex_9010/Kconfig M src/mainboard/google/zork/Kconfig M src/mainboard/protectli/vault_bsw/Kconfig M src/mainboard/supermicro/x9scl/Kconfig M src/mainboard/system76/lemp9/Kconfig 8 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42480/1
diff --git a/src/mainboard/asrock/b85m_pro4/Kconfig b/src/mainboard/asrock/b85m_pro4/Kconfig index 67206a9..7098f94 100644 --- a/src/mainboard/asrock/b85m_pro4/Kconfig +++ b/src/mainboard/asrock/b85m_pro4/Kconfig @@ -20,7 +20,7 @@
config MAINBOARD_DIR string - default asrock/b85m_pro4 + default "asrock/b85m_pro4"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig index 265d0cb..16fbbb8 100644 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig +++ b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig @@ -20,7 +20,7 @@
config MAINBOARD_DIR string - default asus/p8h61-m_lx3_r2_0 + default "asus/p8h61-m_lx3_r2_0"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8z77-v_lx2/Kconfig b/src/mainboard/asus/p8z77-v_lx2/Kconfig index 4e96c59..e084f07 100644 --- a/src/mainboard/asus/p8z77-v_lx2/Kconfig +++ b/src/mainboard/asus/p8z77-v_lx2/Kconfig @@ -18,7 +18,7 @@
config MAINBOARD_DIR string - default asus/p8z77-v_lx2 + default "asus/p8z77-v_lx2"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/dell/optiplex_9010/Kconfig b/src/mainboard/dell/optiplex_9010/Kconfig index 4179f64..3f5893c 100644 --- a/src/mainboard/dell/optiplex_9010/Kconfig +++ b/src/mainboard/dell/optiplex_9010/Kconfig @@ -22,7 +22,7 @@
config MAINBOARD_DIR string - default dell/optiplex_9010 + default "dell/optiplex_9010"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index ab24213..71b7d6d 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -54,7 +54,7 @@
config MAINBOARD_DIR string - default google/zork + default "google/zork"
config VARIANT_DIR string diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig index 499bad4..5850995 100644 --- a/src/mainboard/protectli/vault_bsw/Kconfig +++ b/src/mainboard/protectli/vault_bsw/Kconfig @@ -15,7 +15,7 @@
config MAINBOARD_DIR string - default protectli/vault_bsw + default "protectli/vault_bsw"
config VARIANT_DIR string diff --git a/src/mainboard/supermicro/x9scl/Kconfig b/src/mainboard/supermicro/x9scl/Kconfig index 26ca48a..fb73683 100644 --- a/src/mainboard/supermicro/x9scl/Kconfig +++ b/src/mainboard/supermicro/x9scl/Kconfig @@ -16,7 +16,7 @@
config MAINBOARD_DIR string - default supermicro/x9scl + default "supermicro/x9scl"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index cc21ca9..0fe5e8d 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -23,7 +23,7 @@
config MAINBOARD_DIR string - default system76/lemp9 + default "system76/lemp9"
config MAINBOARD_PART_NUMBER string
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42480 )
Change subject: mb/*/*/Kconfig: guard board name in quotes ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42480 )
Change subject: mb/*/*/Kconfig: guard board name in quotes ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42480 )
Change subject: mb/*/*/Kconfig: guard board name in quotes ......................................................................
mb/*/*/Kconfig: guard board name in quotes
New kconfig dislikes unquoted slashes.
Change-Id: Ief242de081071021b9c904a24535d025f6674270 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42480 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/Kconfig M src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig M src/mainboard/asus/p8z77-v_lx2/Kconfig M src/mainboard/dell/optiplex_9010/Kconfig M src/mainboard/google/zork/Kconfig M src/mainboard/protectli/vault_bsw/Kconfig M src/mainboard/supermicro/x9scl/Kconfig M src/mainboard/system76/lemp9/Kconfig 8 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/Kconfig b/src/mainboard/asrock/b85m_pro4/Kconfig index 67206a9..7098f94 100644 --- a/src/mainboard/asrock/b85m_pro4/Kconfig +++ b/src/mainboard/asrock/b85m_pro4/Kconfig @@ -20,7 +20,7 @@
config MAINBOARD_DIR string - default asrock/b85m_pro4 + default "asrock/b85m_pro4"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig index 265d0cb..16fbbb8 100644 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig +++ b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig @@ -20,7 +20,7 @@
config MAINBOARD_DIR string - default asus/p8h61-m_lx3_r2_0 + default "asus/p8h61-m_lx3_r2_0"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8z77-v_lx2/Kconfig b/src/mainboard/asus/p8z77-v_lx2/Kconfig index 4e96c59..e084f07 100644 --- a/src/mainboard/asus/p8z77-v_lx2/Kconfig +++ b/src/mainboard/asus/p8z77-v_lx2/Kconfig @@ -18,7 +18,7 @@
config MAINBOARD_DIR string - default asus/p8z77-v_lx2 + default "asus/p8z77-v_lx2"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/dell/optiplex_9010/Kconfig b/src/mainboard/dell/optiplex_9010/Kconfig index 4179f64..3f5893c 100644 --- a/src/mainboard/dell/optiplex_9010/Kconfig +++ b/src/mainboard/dell/optiplex_9010/Kconfig @@ -22,7 +22,7 @@
config MAINBOARD_DIR string - default dell/optiplex_9010 + default "dell/optiplex_9010"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 0cc55c9..572daeb 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -54,7 +54,7 @@
config MAINBOARD_DIR string - default google/zork + default "google/zork"
config VARIANT_DIR string diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig index 499bad4..5850995 100644 --- a/src/mainboard/protectli/vault_bsw/Kconfig +++ b/src/mainboard/protectli/vault_bsw/Kconfig @@ -15,7 +15,7 @@
config MAINBOARD_DIR string - default protectli/vault_bsw + default "protectli/vault_bsw"
config VARIANT_DIR string diff --git a/src/mainboard/supermicro/x9scl/Kconfig b/src/mainboard/supermicro/x9scl/Kconfig index 26ca48a..fb73683 100644 --- a/src/mainboard/supermicro/x9scl/Kconfig +++ b/src/mainboard/supermicro/x9scl/Kconfig @@ -16,7 +16,7 @@
config MAINBOARD_DIR string - default supermicro/x9scl + default "supermicro/x9scl"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index cc21ca9..0fe5e8d 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -23,7 +23,7 @@
config MAINBOARD_DIR string - default system76/lemp9 + default "system76/lemp9"
config MAINBOARD_PART_NUMBER string
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)