Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46275 )
Change subject: cpu/intel/common: rework AES-NI locking ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46275/4/src/cpu/intel/common/common... File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46275/4/src/cpu/intel/common/common... PS4, Line 279: msr_unset_and_set
This is where it may still be helpful to have another function like msr_set_bits, that can just call […]
Done
https://review.coreboot.org/c/coreboot/+/46275/5/src/cpu/intel/common/common... File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46275/5/src/cpu/intel/common/common... PS5, Line 280: if (rdmsr(MSR_FEATURE_CONFIG) & AESNI_LOCK) ouch. that won't work ofc.
Well, we could add another helper msr_get:
if (msr_get(MSR_FEATURE_CONFIG) & AESNI_LOCK) // msr_get returns full msr
or maybe
if (msr_get(MSR_FEATURE_CONFIG, AESNI_LOCK)) // msr_get returns bitmask
or just go back to the initial version? :S
-
Michael Niewöhner (Code Review)